Horny Source code on Github

Hello,

Horny source code is available here:
https://github.com/timoinutilis/midi-sequencer-amigaos

Os4 version has an interface problem if someone could fix it

No bug
https://amitheme.amiga-ng.org/amiga/Horny.png

Bug
https://amitheme.amiga-ng.org/amiga/Horny_bug.png

Thank you

I feel so compelled to touch myself now..:D

@sinisrus

I didn't know it was developed in plain C (thought it was C++, which I don't do). I'll see if I can compile it at all.

If you can solve the problem it would be great
Thank you

@sinisrus
What do you mean by interface problems?
Graphic glitches?

I have run the OS4Depot/Inutilis version for years without problem on XE/X5000

EDIT: Looking at your second picture I kinda understand what you mean but that is an empty window,

I think the "dragbar" shows up once you have something to drag - a new midi-track.

But there sure can be bugs since Timo ported it from 68k to PPC.

@sinisrus

No promises, though. The author himself says that the Horny code is horrible, so...

@trixie

no problem it's good to try

@sinisrus

The OS4 GCC version does not compile at the moment due to some errors - I'll look into it, maybe I'm just missing something in my SDK.

@trixie
I give a go to compile Horny-GCC, and that what i had to do:

1). in few files replaced RBNA_Labels on RBNA_Label (i.e. remove "s" at end).

2). Midi.c want proto/eXtreamSync.h , so for that one:http://os4depot.net/share/library/misc/extreamsync.lha

3). in the same Midi.c you get errors about old timer usage, so at top of that Midi.c add :
#define __USE_OLD_TIMEVAL__ 1

4). in such files as Start.c and AppWindow.c
replace CurrentDir() (obsolete dos's one) on SetCurrentDir()


5). at this point all compiles with latest public SDK and gcc 8.2.0 from adtools. Through it fail to link because of CAMD undefs for all functions which want ICamd-> even if you use USE_INLINE. (probabaly CAMD includes need to be fixed a bit).

Anyway, to fix that , we in 3 files such as Midi.c, Einstellungen.c and SysEx.c add before all camd's functions ICamd->. In the Einstellugnen.c and SysEx.c we at top also add "extern struct CamdIFace *ICamd;" so it ICamd-> will works there, as it opened and defined in midi.c

6). now all links fine and we have HornyOS4 binary of 750kb size and 700kb after stripping.

If there needs i can upload those 3 changed files.

Binary even runs (click open in new tab for fullsize):



Through, as far as i can see, there need to do some real code works now. Menus kind of broken a little (probabaly that what was said about "interface" issues), "about" didn't even spawns. On exit it bring "unfreed signals 4000000" , so there need some things to do surely.

Edit: when i open "Mixer" in menu, it even freezes. So yeah, there some bugs there and there which can be fixed of course, if anyone with good coding skills of reaction (like Trixie) will deal with :)

@kas1e

Wow, Roman, you're faster than a child's first curry

Yes please, upload your changes to github and I'll try to take it all from there. Based on your screenshot, it looks like the toolbar buttons at the bottom of the window are broken too.

@Trixie
With github it will take more time for me, so i unstead pack the fixed sources up (all of them) , and upload it there:

http://kas1e.mikendezign.com/aos4/horny/horny_os4_fixed.zip

So just unpack and type "make" to have a binary. That of course in case if you install that extreamsync.lha and camd.lha dev sdks.

I tested it a bit more, and in general, probably fixing those 4 bugs i mention will make it "ok".

Quote:

Ah, is that probably because i just run only pure binary from "RAM:", without any data files :) Maybe that the reasson of most of bugs i have report before, will check now.

@Trixie
Oh yeah, i download form os4depot all Horny's datafiles and stuff, and yeah, now it looks pretty good !

"About" now works fine.
"Mixer" option didn't crahes

And on exit i didn't have now "unfreed signals 0x4000000" but instead "unfreed signals 0x2000000"

Check this out (click open in newtab for fullsize):



So there is left probabaly only 2 issues: unfreed signanls on exit, and interface issues : i see there is no scrollbars indeed as it posted in first image. Like some wrong layoting when build reaction window

@kas1e

OK, thanks. So don't bother with uploading back to github (I don't use it either). Got your files fine now.

@kas1e

Quote:

It shouldn't and using a git repo would make it simpler to see the modifications IMHO.

1) fork the original repo
2) git clone your fork
3) modify the code
4) git status; git diff
5) git add what you want; git commit
6) git push
7) create pull request against original repo
8) profit ?!

@trixie & Kas1e

Ooh, nice to see some effort to make fixes to this program! Those UI bugs have been there for some time.

When sources were released I thought they will rot on github till the end of the world.

@Capehill
I not sure if the original author who put a source of GitHub wants to receive any fixes on his repo. That needs to be dealing with him first. But sure, will be good to have all new fixes in the same repo.

@ kas1e
the author of horny "Timo kloss who put the source code on github. He responds quickly to the email if necessary ...

Well the licence file says quite clearly that we can do anything, so...

Looks like Lyle did some work on it yesterday:

https://amigaworld.net/modules/newbb/v ... _id=42892&forum=27#830559

Funny thing, I was going to do the same yesterday night, but then I thought I had better finish my current A-EON project

@Trixie
Probably as Capehill noted GitHub is still our way. Because as of now its all start to be split between different people, without knowing what who does, and so, everything needs to be in one repo indeed.

I ask Lyle if he can submit that to Tim's repo, or create fork somewhere, or I can create a fork. Just all need to be in one place.