Strange crash with ARexx and RexxReqTools on Amiga OS4

@msteed:

That is a very good point, thank you very much!

I changed the check to the following:

@FlynnTheAvatar


That's good blacklisting would have sorted that out so you could isolate the crash point.

Going over the docs, the usage of WindowPtr looks like a bad idea. It's called WindowPtr so should only contain a window pointer or NULL. This is one of those cases where it has too many possible values. While the bug in this case is in ReqTools and must surely be an old one gone unnoticed all these years, it demonstrates a flaw. Only a positive value can be an address which limits it to a 2GB boundary. Of course these pointers were designed around 40 years ago so an "MFP" (or multi function pointer) looks like a great idea.

Given there's so many values that can be there as well as a valid pointer you may need to check specially for 0, -1 and if neither interpret as pointer. The only shortcut I would trust is (!WindowPtr) to check for NULL.

@pjs

Quote:

on my A1200 Image (3.5 based) I have



I suspect requestDevice is custom though....

@pjs

Quote:
Both RequestChoice and RequestFile are documented in the printed OS 3.1 DOS manual, so those two go back at least that far. No RequestString, though.