Odyssey 1.23 progress: r5 RC2

	Bottom Previous Topic Next Topic
Register To Post

« 1 ... 29 30 31 (32) 33 34 35 ... 72 »

zzd10h

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 0:15 #621

Just can't stay away

@jabirulo
"Catalog (owb.catalog) doesn't seems to be closed on quit/exit, as I can't flush it from memory to test updated/fixed localization"

Even with "expunge locale.library" (or by double-clicking on libraries/Catalogs list of SysMon) ?

tommysammy

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 5:32 #622

Quite a regular

Odyssey1.23 fix2 seems to be better working than original Odyssey 1.23
I have to do more testing
@kas1e can you fix the Ahi bug?
When i am running AmigaAmp and start then a Youtube video, i get no sound of the Youtube video
Start i first a Youtube video then i can not start AmigaAmp
Both programs are using the same Ahi channel. Odyssey need an option to switch the Ahi channel when it is occupied

Amiga600/Vampire2/PrismaMegaMix/32GB CF Card/2x Rys Mk2/A604n/IndivisionECS/Gotek

kas1e

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 10:31 #623

Home away from home

@Jabirulo
Quote:

Catalog (owb.catalog) doesn't seems to be closed on quit/exit, as I can't flush it from memory to test updated/fixed localization. Thus i need to fast reboor miggy to test updated catalog

That strange, because:

locale.cpp:


#include "gui.h"



/* public */

#include <proto/dos.h>

#include <proto/exec.h>

#include <proto/locale.h>

#include <libraries/locale.h>



/* private */

#include "alocale.h"

#include "owb_cat.h"



static struct Catalog *catalog;



struct Locale *locale;



LONG   locale_timezone_offset;



ULONG locale_init(void)

{    

    locale = OpenLocale(NULL);



    locale_timezone_offset = -locale->loc_GMTOffset * 60;



    catalog = OpenCatalog(

        NULL, "OWB.catalog",

        OC_BuiltInLanguage, "english",

        OC_Version, 1,  /* required catalog version */

        TAG_DONE

    );



    if (catalog)

    {

        int c;



        for (c = 0; c < NUMCATSTRING; c++)

        {    

            #ifdef __amigaos4__

            ((char**)__stringtable)[ c ] = (char *)GetCatalogStr(catalog, c, (char*)__stringtable[c]);

            #else

            ((char**)__stringtable)[ c ] = GetCatalogStr(catalog, c, (char*)__stringtable[c]);

            #endif

        }

    }

    return (TRUE);

}



void locale_cleanup(void)

{

    CloseLocale(locale);

    CloseCatalog(catalog);

}

And then, in the main:


if(open_libs())

    {

        if(safety_check())

        {

            app = create_application(argc > 1 ? (char*)argv[1] : (char *)"");



            if(app)

            {

                main_loop();

            }



            destroy_application();

        }

    }

    close_libs();

Where destroy_application() are:


void destroy_application(void)

{

    if(app)

    {

        MUI_DisposeObject(app);

        methodstack_cleanup();

        classes_cleanup();

        locale_cleanup();

        app = NULL;

    }

}

So probably it should be ok.

Join us to improve dopus5!
AmigaOS4 on youtube

tboeckel

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 10:43 #624

Just popping in

locale_cleanup() should be called independently of the application object.

Why stop it now, just when I am hating it?

Thore Böckelmann

kas1e

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 11:26 #625

Home away from home

@Thore
Why ?

Join us to improve dopus5!
AmigaOS4 on youtube

Breed

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 12:33 #626

Just popping in

Big thank you, fixed version seems to work much smoother on my X1000.
Now I can listen AmigaRemix songs via OWB and netradio stations wich I have listened using OWB seems to working better (earlier versions ate memory after about one hour listening and then my Amy crached)
ps: small motivation donation sent, I recomment to all

\o/....X1000....\o/

tboeckel

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 12:49 #627

Just popping in

@ kas1e

Because the catalog will be closed only if creating the application succeeded before. Otherwise you have a memory leak. Unprobable, but not impossible. I don't know how safety_check() and create_application() look like, but I suppose the catalog will be opened before the application is created.

Why stop it now, just when I am hating it?

Thore Böckelmann

MickJT

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 13:25 #628

Just can't stay away

@kas1e

http://www.amigans.net/modules/xforum/viewtopic.php?post_id=99737

Building it against the latest OpenSSL should fix that.

trixie

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 14:34 #629

Amigans Defender

@kas1e

Thank you for the upload! A brief report from me:

- Odyssey registers as a commodity. I guess this is unnecessary? Why would a 60MB mammoth browser application want to be a commodity? Commodities are primarily service programs.

- The commodity support is broken anyway. Upon receiving CXCMD_DISAPPEAR Odyssey iconifies instead of hiding; this is contrary to the usual conventions. If the program receives a CXCMD_KILL when it is iconified, Odyssey neither quits, nor can it be uniconified again: the icon just stays "locked" on the WB. (I suspect the CXCMD_KILL-handling code does not account for the window being not open at the moment the message arrives.)

- Odyssey registers as an application but there is virtually no application.library support. The program does not respond to APPLIBMT_Hide or APPLIBMT_Unhide messages, although iconification is apparently supported. APPLIBMT_Quit is not implemented either.

I can fix this for you if this part is in plain C.

The Rear Window blog

AmigaOne X5000 @ 2GHz / 4GB RAM / Radeon RX 560 / ESI Juli@ / AmigaOS 4.1 Final Edition
SAM440ep-flex @ 667MHz / 1GB RAM / Radeon 9250 / AmigaOS 4.1 Final Edition

LiveForIt

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 14:49 #630

Home away from home

@kas1e


void locale_cleanup(void) 

{ 

    CloseLocale(locale); 

    CloseCatalog(catalog); 

}

This code, you can make safer by doing:


void locale_cleanup(void) 

{ 

   if (locale) CloseLocale(locale); 

   if (catalog) CloseCatalog(catalog); 



   locale = NULL; catalog = NULL;

}

This prevent nasty crashes, If local_cleanup() is called more than once, by accident, or things like that. That’s how I always do my clean up code. And this make easier to find issues where locale might be used after its freed and so on.

nubechecorre

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 21:19 #631

Just can't stay away

@kas1e

I am testing the second version (Deadwood) right now... let's see if it works or crash.. :)

mbrantley

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 22:44 #632

Not too shy to talk

Thanks for working on this. It's certainly a very important program for the platform.

zzd10h

Re: Odyssey 1.23 progress

Posted on: 2016/1/9 23:56 #633

Just can't stay away

@Kas1e
As building a cross-compiler system seems to be a real pain, could you share your Linux system (in ISO format) ?

Because, if you left Amiga world (as all normal man should do) we will not be able to build Odyssey again.

PS : if you are around, you could reply, too, to my another question about OWB mediaplayer, by politeness...

http://apps.amistore.net/zTools

nubechecorre

Re: Odyssey 1.23 progress

Posted on: 2016/1/10 0:11 #634

Just can't stay away

after some testing (about 2 hours) it doesn't crash anymore... maybe first time was just a random crash due to the system..

zzd10h

Re: Odyssey 1.23 progress

Posted on: 2016/1/10 0:14 #635

Just can't stay away

magnetic

Re: Odyssey 1.23 progress

Posted on: 2016/1/10 3:39 #636

Just popping in

@zzd10h

What do you mean kas1e left the amiga world? Outside of the the developers on staff he was one of the best things for NG amiga going!

mbrantley

Re: Odyssey 1.23 progress

Posted on: 2016/1/10 5:10 #637

Not too shy to talk

@magnetic

Think he meant "if," as in "if you ever did." But he can say different if I am wrong.

zzd10h

Re: Odyssey 1.23 progress

Posted on: 2016/1/10 8:25 #638

Just can't stay away

@magnetic
As mbrantley said, i mean "if ever you wanted to leave..."

radzik

Re: Odyssey 1.23 progress

Posted on: 2016/1/10 8:33 #639

Just popping in

@zzd10h

That's why it would be the best to have small team developing Odyssey for all 3 NG systems. Now Fab is (temporary?) out and Odyssey for PowerPC is dead. First of all we must find someone to fix WebKit for PPC.

I can't imagine AmigaOS4 without modern browser.

kas1e

Re: Odyssey 1.23 progress

Posted on: 2016/1/10 8:49 #640

Home away from home

@Trixie
Do not remember if and why odyssey should be a commoditie (maybe side effect of using some other libs ? Do not remember). But about application.library : i added it only for making ringio notifications. Do you think there is needs for full support ?

@zzd10h
Quote:

As building a cross-compiler system seems to be a real pain, could you share your Linux system (in ISO format) ?

Nope, because my linux system is cygwin installation over 10gb, +10-20gb of all kind of amiga ports and shit of all kind flying around in cygwin files, which i can't and wan't distribute, what mean that to making that "linux system iso format" will mean clean everything up (a loooot of boring work).

And in end of all, making crosscompilation setups is pain only for lazy ppls :) Its nothing pain to have linux and install SDK on it, or to have cygwin on windows with the same SDK.

@MickJT
Quote:

Building it against the latest OpenSSL should fix that.

If linking with new version of openssl will not bring new bugs by any reasson (what usually happens), then why not, we can try.

Edited by kas1e on 2016/1/10 11:22:51

Register To Post	« 1 ... 29 30 31 (32) 33 34 35 ... 72 »
	Top Previous Topic Next Topic

Currently Active Users Viewing This Thread: 4 ( 0 members and 4 Anonymous Users )