RHash bug

	Bottom Previous Topic Next Topic
Register To Post

ChrisH

RHash bug

Posted on: 2016/2/4 12:40 #1

Home away from home

I'm currently using this very handy port of RHash, which seems compatible with the Windows version:
http://os4depot.net/index.php?functio ... tility/filetool/rhash.lha

I noticed a bug: Recursive mode doesn't work if the specified folder is the root of the volume, such as Work: .

I couldn't find any contact information :( , so posting here (as well as on OS4 Depot comments) in case the mysterious porter/uploader happens to spot this... (Or someone else knows them & can point them here.)

Author of the PortablE programming language.

ddni

Re: RHash bug

Posted on: 2016/2/4 13:03 #2

Just can't stay away

@ChrisH

renewolsen/gmail com

/ =@ space=.

AmigaOne X1000.
Radeon RX550

http://www.tinylife.org.uk/

rwo

Re: RHash bug

Posted on: 2016/2/4 13:10 #3

Not too shy to talk

@ddni

There are two utils called RHash and he is not using my version.

“The best thing about a boolean is even if you are wrong, you are only off by a bit.”

ddni

Re: RHash bug

Posted on: 2016/2/4 13:28 #4

Just can't stay away

@rwo

Ahh sorry Chris. Thx RWO.

AmigaOne X1000.
Radeon RX550

http://www.tinylife.org.uk/

salass00

Re: RHash bug

Posted on: 2016/2/4 13:30 #5

Just can't stay away

@ChrisH

Have you tried specifying the path as "/Work" instead of "Work:"?

ChrisH

Re: RHash bug

Posted on: 2016/2/4 13:34 #6

Home away from home

@salass00
No, because "Work:some/folder" works just fine. But "Work:" doesn't.

Author of the PortablE programming language.

broadblues

Re: RHash bug

Posted on: 2016/2/4 17:39 #7

Home away from home

@ChrisH

Quote:

No, because "Work:some/folder" works just fine. But "Work:" doesn't.

It's quite common issue with libunix based apps to not read files in the root dir correctly when present with that dir in AmigaOS format.

So do as you are told and try /Work

Blender For OS4.x : Blues : Walker Broad

ChrisH

Re: RHash bug

Posted on: 2016/2/4 19:59 #8

Home away from home

@broadblues
Sadly /Work does not work (nor similar variations). The problem is that it seems to treat Work: as if it was a folder, and so when it tries to enter (say) Work:example the path it tries to use is Work:/example .

Author of the PortablE programming language.

Chris

Re: RHash bug

Posted on: 2016/2/4 23:45 #9

Amigans Defender

@ChrisH

Quote:

Work:/example

Of course it's up to the filesystem how it interprets that. I thought that a request for the parent of root returned root, at least on FFS. I've just checked and only ram-handler (and my webdav-handler, more by accident than design) treats the parent of root as root, smbfs redirects to SYS: (I'd consider this a bug) and FFS and SFS2 error it as an invalid path.

I'm not blaming the filesystems btw, I find path handling is often broken on lazy ports.

If you want a workaround you could create a soft-link in RAM: pointing to the volume you actually want to scan, and scan the link instead. That should work.

salass00

Re: RHash bug

Posted on: 2016/2/5 10:22 #10

Just can't stay away

@Chris

Quote:

Of course it's up to the filesystem how it interprets that. I thought that a request for the parent of root returned root, at least on FFS. I've just checked and only ram-handler (and my webdav-handler, more by accident than design) treats the parent of root as root, smbfs redirects to SYS: (I'd consider this a bug) and FFS and SFS2 error it as an invalid path.

The correct response for ACTION_PARENT/FSParentDir() on a root lock is:

Res1: ZERO
Res2: 0 (no error)

Quoting from dos.dospackets.doc:
Quote:

If the lock has no parent, then a lock of ZERO is returned. No secondary error code shall be returned for ZERO root locks.

thomas

Re: RHash bug

Posted on: 2016/2/5 16:00 #11

Not too shy to talk

Which means that SMBFS is the only one which does it right.

Quote:

smbfs redirects to SYS: (I'd consider this a bug)

Elwood

Re: RHash bug

Posted on: 2016/2/5 17:13 #12

Just can't stay away

Author of the other version is rhash.admin on gmail , com

Philippe 'Elwood' FERRUCCI
Sam460ex 1.10 Ghz
http://elwoodb.free.fr

Chris

Re: RHash bug

Posted on: 2016/2/5 18:45 #13

Amigans Defender

@thomas

Surely a lock of 0 is an error code, rather than equivalent to SYS:?

This also assumes "dir ram:/t" uses ACTION_PARENT to try to construct a sensible path, which it might not.

Either way, sounds like at least ram-handler has a bug.

ChrisH

Re: RHash bug

Posted on: 2016/2/6 17:10 #14

Home away from home

never mind!

Author of the PortablE programming language.

rwo

Re: RHash bug

Posted on: 2016/2/13 3:35 #15

Not too shy to talk

@ChrisH

Hey Chris.. I just wanted to mention I added support for SFV File Generation.

Not sure if this was the option you used in the other rhash.

My have rHash command has standard Amiga DOS wildcard support, so 'Work:' should work.

René

“The best thing about a boolean is even if you are wrong, you are only off by a bit.”

ChrisH

Re: RHash bug

Posted on: 2016/2/13 11:34 #16

Home away from home

@Elwood Quote:

Author of the other version is rhash.admin on gmail , com

Are you SURE about that? That's the email address of the ORIGINAL author (Aleksey Kravchenko). I have no reason to think that he was the one responsible for the OS4 port...

Author of the PortablE programming language.

ChrisH

Re: RHash bug

Posted on: 2016/2/13 11:37 #17

Home away from home

@rwo Quote:

Hey Chris.. I just wanted to mention I added support for SFV File Generation.

I don't know, I used whatever the default format was. It's homepage does mention SFV, so I guess that's the case. In which case your program might be a better solution if I need to do this again :)

Author of the PortablE programming language.

Elwood

Re: RHash bug

Posted on: 2016/2/14 22:26 #18

Just can't stay away

@ChrisH

Oops, sorry you're right.

Philippe 'Elwood' FERRUCCI
Sam460ex 1.10 Ghz
http://elwoodb.free.fr

Register To Post
	Top Previous Topic Next Topic

Currently Active Users Viewing This Thread: 2 ( 0 members and 2 Anonymous Users )