You could also add the Enhancer wave and mpega (assuming thats the datatype playing MP3 sound files). I was considering changing the USBSound code to calculate the sound play time from the SDTA_SamplesPerSec and SDTA_SampleLength attributes but the Enhancer wave and mpega datatypes return 0 for the sample length.
I'm not sure about this, mpega at least might be a streaming subclass I think I'll just email Kevin and ask him to look at this thread ...
Quote:
Also both the Enhancer and OS4FE sound.datatype return incorrect SDTA_SamplesPerSec, SDTA_BitsPerSample & SDTA_SampleLength for CDDA sounds files ripped from a music CD. They return 8 bit samples at 22050 samplerate and questionable sample length. You can include that it a bug report to AmigaKit and the OS4.1 bugzilla.
You have to set the sample size to 16 or 32 (or 24 or float with the new aeon one) or else the samples are always converted to 8bit, for compatabilty I suppose, at least that's how I read the autodoc.
I could also be down to the cdda subclass, especially if it's old.
You have to set the sample size to 16 or 32 (or 24 or float with the new aeon one) or else the samples are always converted to 8bit, for compatabilty I suppose, at least that's how I read the autodoc.
My reading of the autodoc states that for cases where AHI is unavailable.
Hopefully, the issues I've pointed out will be fixed (especially SDTA_ReplayPeriod).
Thanks for helping and looking into this.
Amiga X1000 with 2GB memory & OS 4.1FE + Radeon HD 5450
Unless Kevin made another update since I emailed him last night (and it was quite late at that point) in response to the first fix, then only the first of thr two issues is fixed at this point.
I'm sure the second fix wil be just as quick, but just flagging it up to avoid confusuion.
@broadblues I PM'd Amigakit but didn't get a binary. However, you know what the problems are and can test an updated sound.datatype before it's release.
Amiga X1000 with 2GB memory & OS 4.1FE + Radeon HD 5450
I just received your email and replied. The new (fixed) datatypes fix the problem with external sound files in my USBSound porgram. The 8svx and WAV datatypes now return fairly accurate time, samplesize & sample length. The mpega datatype is now returning the same attributes accurately for MP3 files but that may depend on the accuracy of the MP3 file header.
The time for CDDA files seems accurate but both the new Enhancer sound. datatype AND the OS4.1FEu1 sound.datatype show exactly half the samplesize and samplerate with questionable sample length. That may be because (as the autodoc states) CDDA sounds are converted to 8 bit samples at half the samplerate if AHI is unavailable. That may have likely been the case for OS3 but AHI will always be used in OS4 so it wouldn't hurt to change an OS4 sound.datatype to return the correct attributes (16 bit at 44,100 sample rate (freq)).
I'm happy with the fixed datypes and other programmers & users will probably be happy too.
Thanks for the quick turnaround on my bug report.
Amiga X1000 with 2GB memory & OS 4.1FE + Radeon HD 5450
The CDDA datatype is quite ancient, much like the FLAC datatype I discussed in a related email, therefore they probably downsample to 8 bits when decoding the file.
Only sound datatype sub classes since 2011 are likely to be aware of the 16/32 sample size support in sound.datatype, and only the a-eon ones are likely to support the new 24/float sample size options.
The CDDA datatype is quite ancient, much like the FLAC datatype I discussed in a related email, therefore they probably downsample to 8 bits when decoding the file.
Only sound datatype sub classes since 2011 are likely to be aware of the 16/32 sample size support in sound.datatype, and only the a-eon ones are likely to support the new 24/float sample size options.
Actually, I think CDDA music files are being played by the aiff.datatype and it's probably that datatype that needs to be updated by A-EON or the OS4 devs in order to have it play 16 bit sound and report 16 bit attributes.
I'm suggesting that aiff.datatype be updated. If Kevin has the skills to create the mpega.datatype and an updated WAV datatype, I'm assuming he could create an updated aiff.datatype for the next Enhancer release
Amiga X1000 with 2GB memory & OS 4.1FE + Radeon HD 5450
Since I installed the update to the Enhancer package, I have completely lost Ringhio notifications. No programmes give a notification, and when I run Prefs and click Test, nothing happens.
That's exactly the problem I had, and Notification Prefs was crashing too. I ended up reverting to the previous version of both and still had to reset to defaults in prefs before notifications started appearing again.
@Chris Maybe the updated Ringhio will work for you, now that you've reset your preferences? Should be easy to test, as you can extract/copy the new Ringhio Server somewhere, and temporarily have WbStartup run it instead of the original.
I figured it out. When I open Notification Prefs, Screen Coverage, Pop-Up Transparency, and Pop-Up time all have a default value of 0. So, no notifications.
I have to move the sliders to select a value. It seems very buggy to have a default value that isn't even selectable. Also, Transparency ranges from 180 % to 255 % ????
A lot of the other values that are selected by default aren't recognised by the programme. For example, the default position according to the GUI is bottom right. If I click Test, the notification is bottom left. If I actually want it bottom right I have to select another value (e.g., Bottom Left) and then re-select bottom right.
So it's a pretty buggy GUI.
Possibly, as ChrisH said, it might work for you now that you've re-set your preferences?
News feed
OS4 Feedback forum
OS4Depot Feedback forum
Amigabounty forum
OpenAmiga forum
AmiCygnix forum
ABC shell forum
AmiKit forum
Cinnamon Writer forum
CodeBench forum
Digital Universe forum
Dopus 5 forum
E-UAE forum
Gnash forum
Ibrowse forum
JAmiga forum
Odyssey forum
OWB forum
Qt forum
SmartFileSystem forum
Timberwolf forum
TouchDevice forum
TuneNet forum
Unsatisfactory Software forum
Donate
