SDL2

@Capehill

Tested SDLBenchmark and it works and it exit ok, however after a while that i use the system i got an "Out of memory" from ELF message

And then a crash:

Quote:

@samo79

Stack trace doesn't really match with your description. You said that application exited but crashed after a while? How much stack do you have for WB and shell?

I have tested benchmark with WinUAE and Sam440. Seems to be OK here. Raziel had also a different kind of crash. Something broken somewhere..

@Capehill

Quote:

Stack: 32768

@samo79

That's not much. I haven't checked how much sdl2benchmark uses but my WinUAE setup for example has 64 KB for both Workbench and shell apps.

@Capehill

Don't know, that stack it's what i had by default and i never touched it

@samo79

Can you reproduce issue? Can you get a full serial log?

@Capehill
Tested also latest iconification branch: now it takes icon correctly : when there is no icon it bring on WB default icon, when there is an icon, it takes it instead => yeah ! cool ! all as it should be.

Through, it didn't take name of binary when placed icon on WB, but takes what is print in the title of window. So for example in one of my tests, i have on wb game's icon, with "Test Game done by XXX, for blalblal XXX 102.3831", while name of binary "test" (and that what should be in the icon decription when it placed on WB, imho).

But good work, its really handy !

@all

It seems there is a SDL2 version of Freespace2

http://scp.indiegames.us/

Version 2.0.7 released: https://github.com/AmigaPorts/sdl2-amigaos4/releases

Work starts towards 2.0.8 release and development moves to this repo https://github.com/AmigaPorts/SDL which is already up-to-date with upstream.

@Capehill

Using SDL2 Version 2.0.7 released: https://github.com/AmigaPorts/sdl2-amigaos4/releases on my SAM460ex (RadeonHD 6570)

#sdl2benchmark
INFO: SDL2 renderer benchmark v. 0.5 (SDL version 2.0.7)
INFO: This tool measures the speed of various 2D drawing features
INFO: Press any key to quit
INFO: Parameters: width 800, height 600, renderer name '(null)', iterations 100, objects 100, sleep 0
INFO: Image size 408*167
INFO: Pixel format 0x16161804 (SDL_PIXELFORMAT_RGB888)
INFO: Starting to test renderer called [compositing], flags 0xE
INFO: Points [mode: None]...100 frames drawn in 0.068 seconds => 1468.4 frames per second
INFO: Points [mode: Blend]...100 frames drawn in 0.058 seconds => 1734.1 frames per second
INFO: Points [mode: Add]...100 frames drawn in 0.058 seconds => 1739.1 frames per second
INFO: Points [mode: Mod]...100 frames drawn in 0.058 seconds => 1724.0 frames per second
INFO: Lines [mode: None]...100 frames drawn in 0.325 seconds => 307.6 frames per second
INFO: Lines [mode: Blend]...100 frames drawn in 1.816 seconds => 55.1 frames per second
INFO: Lines [mode: Add]...100 frames drawn in 1.764 seconds => 56.7 frames per second
INFO: Lines [mode: Mod]...100 frames drawn in 1.823 seconds => 54.9 frames per second
INFO: FillRects [mode: None]...100 frames drawn in 0.327 seconds => 306.0 frames per second
INFO: FillRects [mode: Blend]...100 frames drawn in 0.436 seconds => 229.5 frames per second
INFO: FillRects [mode: Add]...100 frames drawn in 0.435 seconds => 229.7 frames per second
INFO: FillRects [mode: Mod]...100 frames drawn in 0.436 seconds => 229.2 frames per second
INFO: RenderCopy [mode: None]...100 frames drawn in 0.053 seconds => 1896.7 frames per second
INFO: RenderCopy [mode: Blend]...100 frames drawn in 0.056 seconds => 1791.8 frames per second
INFO: RenderCopy [mode: Add]...100 frames drawn in 0.054 seconds => 1847.1 frames per second
INFO: [prepareTexture]Failed to set texture blend mode:
INFO: RenderCopyEx [mode: None]...100 frames drawn in 0.052 seconds => 1919.1 frames per second
INFO: RenderCopyEx [mode: Blend]...100 frames drawn in 0.054 seconds => 1866.0 frames per second
INFO: RenderCopyEx [mode: Add]...100 frames drawn in 0.054 seconds => 1854.3 frames per second
INFO: [prepareTexture]Failed to set texture blend mode:
INFO: Color modulation [mode: None]...100 frames drawn in 0.295 seconds => 339.3 frames per second
INFO: Color modulation [mode: Blend]...100 frames drawn in 0.299 seconds => 334.5 frames per second
INFO: Color modulation [mode: Add]...100 frames drawn in 0.294 seconds => 340.6 frames per second
INFO: [prepareTexture]Failed to set texture blend mode:
INFO: Alpha modulation [mode: None]...100 frames drawn in 0.053 seconds => 1897.0 frames per second
INFO: Alpha modulation [mode: Blend]...100 frames drawn in 0.054 seconds => 1849.2 frames per second
INFO: Alpha modulation [mode: Add]...100 frames drawn in 0.054 seconds => 1847.1 frames per second
INFO: [prepareTexture]Failed to set texture blend mode:
INFO: UpdateTexture [mode: None]...100 frames drawn in 0.079 seconds => 1267.0 frames per second, 1317.7 operations per second
INFO: UpdateTexture [mode: Blend]...100 frames drawn in 0.080 seconds => 1247.4 frames per second, 1297.3 operations per second
INFO: UpdateTexture [mode: Add]...100 frames drawn in 0.085 seconds => 1174.4 frames per second, 1221.4 operations per second
INFO: [prepareTexture]Failed to set texture blend mode:
INFO: ReadPixels [mode: None]...0 frames drawn in 0.834 seconds => 0.0 frames per second, 119.9 operations per second
INFO: ReadPixels [mode: Blend]...0 frames drawn in 0.893 seconds => 0.0 frames per second, 112.0 operations per second
INFO: ReadPixels [mode: Add]...0 frames drawn in 0.850 seconds => 0.0 frames per second, 117.6 operations per second
INFO: [prepareTexture]Failed to set texture blend mode:
INFO: Starting to test renderer called [opengl], flags 0x2
INFO: Points [mode: None]...100 frames drawn in 0.159 seconds => 630.7 frames per second
INFO: Points [mode: Blend]...100 frames drawn in 0.159 seconds => 628.2 frames per second
INFO: Points [mode: Add]...100 frames drawn in 0.154 seconds => 650.1 frames per second
INFO: Points [mode: Mod]...100 frames drawn in 0.154 seconds => 649.6 frames per second
INFO: Lines [mode: None]...100 frames drawn in 0.428 seconds => 233.5 frames per second
INFO: Lines [mode: Blend]...100 frames drawn in 0.434 seconds => 230.2 frames per second
INFO: Lines [mode: Add]...100 frames drawn in 0.426 seconds => 234.5 frames per second
INFO: Lines [mode: Mod]...100 frames drawn in 0.433 seconds => 230.8 frames per second
INFO: FillRects [mode: None]...100 frames drawn in 1.155 seconds => 86.6 frames per second
INFO: FillRects [mode: Blend]...100 frames drawn in 1.156 seconds => 86.5 frames per second
INFO: FillRects [mode: Add]...100 frames drawn in 1.158 seconds => 86.3 frames per second
INFO: FillRects [mode: Mod]...100 frames drawn in 1.155 seconds => 86.6 frames per second
INFO: RenderCopy [mode: None]...100 frames drawn in 0.131 seconds => 765.8 frames per second
INFO: RenderCopy [mode: Blend]...100 frames drawn in 0.139 seconds => 717.9 frames per second
INFO: RenderCopy [mode: Add]...100 frames drawn in 0.134 seconds => 744.3 frames per second
INFO: RenderCopy [mode: Mod]...100 frames drawn in 0.134 seconds => 746.1 frames per second
INFO: RenderCopyEx [mode: None]...100 frames drawn in 0.134 seconds => 745.4 frames per second
INFO: RenderCopyEx [mode: Blend]...100 frames drawn in 0.138 seconds => 726.2 frames per second
INFO: RenderCopyEx [mode: Add]...100 frames drawn in 0.137 seconds => 730.1 frames per second
INFO: RenderCopyEx [mode: Mod]...100 frames drawn in 0.143 seconds => 699.3 frames per second
INFO: Color modulation [mode: None]...100 frames drawn in 0.125 seconds => 798.3 frames per second
INFO: Color modulation [mode: Blend]...100 frames drawn in 0.126 seconds => 796.2 frames per second
INFO: Color modulation [mode: Add]...100 frames drawn in 0.127 seconds => 786.1 frames per second
INFO: Color modulation [mode: Mod]...100 frames drawn in 0.126 seconds => 795.2 frames per second
INFO: Alpha modulation [mode: None]...100 frames drawn in 0.131 seconds => 763.2 frames per second
INFO: Alpha modulation [mode: Blend]...100 frames drawn in 0.140 seconds => 715.5 frames per second
INFO: Alpha modulation [mode: Add]...100 frames drawn in 0.136 seconds => 735.9 frames per second
INFO: Alpha modulation [mode: Mod]...100 frames drawn in 0.134 seconds => 744.6 frames per second
INFO: UpdateTexture [mode: None]...100 frames drawn in 0.148 seconds => 675.8 frames per second, 702.9 operations per second
INFO: UpdateTexture [mode: Blend]...100 frames drawn in 0.151 seconds => 660.6 frames per second, 687.0 operations per second
INFO: UpdateTexture [mode: Add]...100 frames drawn in 0.152 seconds => 659.9 frames per second, 686.2 operations per second
INFO: UpdateTexture [mode: Mod]...100 frames drawn in 0.156 seconds => 639.9 frames per second, 665.5 operations per second
INFO: ReadPixels [mode: None]...0 frames drawn in 1.331 seconds => 0.0 frames per second, 75.2 operations per second
INFO: ReadPixels [mode: Blend]...0 frames drawn in 1.308 seconds => 0.0 frames per second, 76.5 operations per second
INFO: ReadPixels [mode: Add]...0 frames drawn in 1.318 seconds => 0.0 frames per second, 75.8 operations per second
INFO: ReadPixels [mode: Mod]...0 frames drawn in 1.283 seconds => 0.0 frames per second, 77.9 operations per second
INFO: Failed to create renderer: Failed to create OpenGL ES 2 context
INFO: Starting to test renderer called [software], flags 0x9
INFO: Points [mode: None]...100 frames drawn in 0.328 seconds => 305.1 frames per second
INFO: Points [mode: Blend]...100 frames drawn in 0.325 seconds => 307.6 frames per second
INFO: Points [mode: Add]...100 frames drawn in 0.325 seconds => 307.6 frames per second
INFO: Points [mode: Mod]...100 frames drawn in 0.331 seconds => 302.4 frames per second
INFO: Lines [mode: None]...100 frames drawn in 0.697 seconds => 143.4 frames per second
INFO: Lines [mode: Blend]...100 frames drawn in 0.996 seconds => 100.4 frames per second
INFO: Lines [mode: Add]...100 frames drawn in 1.001 seconds => 99.9 frames per second
INFO: Lines [mode: Mod]...100 frames drawn in 0.990 seconds => 101.0 frames per second
INFO: FillRects [mode: None]...100 frames drawn in 2.835 seconds => 35.3 frames per second
INFO: FillRects [mode: Blend]...100 frames drawn in 8.116 seconds => 12.3 frames per second
INFO: FillRects [mode: Add]...100 frames drawn in 7.631 seconds => 13.1 frames per second
INFO: FillRects [mode: Mod]...100 frames drawn in 7.076 seconds => 14.1 frames per second
INFO: RenderCopy [mode: None]...100 frames drawn in 0.528 seconds => 189.4 frames per second
INFO: RenderCopy [mode: Blend]...100 frames drawn in 0.997 seconds => 100.3 frames per second
INFO: RenderCopy [mode: Add]...100 frames drawn in 0.944 seconds => 105.9 frames per second
INFO: RenderCopy [mode: Mod]...100 frames drawn in 0.902 seconds => 110.8 frames per second
INFO: RenderCopyEx [mode: None]...100 frames drawn in 7.114 seconds => 14.1 frames per second
INFO: RenderCopyEx [mode: Blend]...100 frames drawn in 2.216 seconds => 45.1 frames per second
INFO: RenderCopyEx [mode: Add]...100 frames drawn in 3.064 seconds => 32.6 frames per second
INFO: RenderCopyEx [mode: Mod]...100 frames drawn in 4.493 seconds => 22.3 frames per second
INFO: Color modulation [mode: None]...100 frames drawn in 0.424 seconds => 235.9 frames per second
INFO: Color modulation [mode: Blend]...100 frames drawn in 0.470 seconds => 212.6 frames per second
INFO: Color modulation [mode: Add]...100 frames drawn in 0.465 seconds => 214.9 frames per second
INFO: Color modulation [mode: Mod]...100 frames drawn in 0.455 seconds => 220.0 frames per second
INFO: Alpha modulation [mode: None]...100 frames drawn in 0.724 seconds => 138.0 frames per second
INFO: Alpha modulation [mode: Blend]...100 frames drawn in 1.141 seconds => 87.6 frames per second
INFO: Alpha modulation [mode: Add]...100 frames drawn in 1.081 seconds => 92.5 frames per second
INFO: Alpha modulation [mode: Mod]...100 frames drawn in 0.970 seconds => 103.1 frames per second
INFO: UpdateTexture [mode: None]...100 frames drawn in 0.754 seconds => 132.6 frames per second, 137.9 operations per second
INFO: UpdateTexture [mode: Blend]...100 frames drawn in 1.174 seconds => 85.2 frames per second, 88.6 operations per second
INFO: UpdateTexture [mode: Add]...100 frames drawn in 1.106 seconds => 90.5 frames per second, 94.1 operations per second
INFO: UpdateTexture [mode: Mod]...100 frames drawn in 1.025 seconds => 97.5 frames per second, 101.4 operations per second
INFO: ReadPixels [mode: None]...0 frames drawn in 0.129 seconds => 0.0 frames per second, 777.4 operations per second
INFO: ReadPixels [mode: Blend]...0 frames drawn in 0.125 seconds => 0.0 frames per second, 800.0 operations per second
INFO: ReadPixels [mode: Add]...0 frames drawn in 0.128 seconds => 0.0 frames per second, 781.0 operations per second
INFO: ReadPixels [mode: Mod]...0 frames drawn in 0.132 seconds => 0.0 frames per second, 760.3 operations per second
INFO: Bye bye
#

@Capehill
Tested latest iconification branch: all fine now. At least i tested with gigalomania game, it takes icon , name of binary, etc all correctly now.

Is it possible to add that iconification's code to the SDL1 too ?

@kas1e

Screen notification didn't work with the SDL test programs so it has to be fixed or removed. If I remember correctly, SDL1 already contains some iconification code but I haven't tested it. Probably iconification in SDL1 is slightly simpler than in SDL2 because SDL1 has only one window ever.

@Capehill

Not sure if this is SDL or OpenGL related, but i get a complete freeze (no crash, nothing on serial) on quitting ScummVM when in window mode.

The last line before the system freeze is *always* "hiding window", no matter if i'm in a game or in ScummVM's launcher.

Thanks for any hints

@Raziel

Did the "freeze at quit" problem appear recently or was it there always?

OS4_HideWindow() doesn't seem to be doing much.

I will try to reproduce issue at some point, hopefully next week.

@Capehill

Well, i didn't really test it much, as i'm normally only doing fullscreen.

The first time it happened was, when a rather new game entry started freezing.

I was able to corner the problem to the game opening a window before
switching to fullscreen but instantly quitting while in window mode due to
a bug in the game.

Then i tried with other games and finally with the launcher itself.

Might be a rather "old" problem, yes.

Thank you for checking

@Capehill

Issue #39 on sf.net updated

The freeze quit only happens when using "OpenGL" inside ScummVM, easy to test too, as you don't need a game, just open the launcher, switch to SummVM and try to close the window.

@Raziel

Ok. I'm trying to get 2.0.8 RC1 out for testing and perhaps after that I will try to reproduce the OpenGL freeze. (Grim Fandango I only have for PlayStation so cannot probably reproduce that issue)

@Capehill

For the ticket 7 (https://github.com/AmigaPorts/sdl2-amigaos4/issues/7)

Don't know if it will be easy as we speak but can you reuse the same code of the old SDL1 ?

@samo79

AmigaOS version strings have format "major.minor" while SDL library uses "major.minor.patch". I'm wondering whether the version could be expressed as "majorminor.patch" (20.8)? It would work at least upto minor version 9.

RC1 is available: https://github.com/AmigaPorts/SDL/releases/tag/v2.0.8-rc1-amigaos4