Porting to AmigaOS4 thread

	Bottom Previous Topic Next Topic
Register To Post

(1) 2 3 4 ... 22 »

Raziel

Posted on: 2019/2/13 13:20 #1

Home away from home

Since nobody done it and i really need (want) a central meeting point of all questions porting i start a thread here (yes, i know about OS4Porting and the IRC and some other sites, but i'm not going to register to any more sites, so...)

First question:

I'm trying to port (from scratch) a program (available for linux, windows, mac and android, so i guess pretty portable already) but am stuck with a compiler error which "seems" to be really easy to fix, but alas it's not.

This is the snippet from the file in question (src/dctypes.h, lines 31-40)


...

#include <string>

#include <list>

#include <vector>



using namespace std;





typedef std::string AnsiString;

typedef std::string Utf8String;

typedef std::wstring WideString;

...

and this is the error the compiler is throwing...obviously the mentioned "fix" doesn't comply as #include <string> is already in place


mkdir -p obj

g++ -c -o obj/AdActor.o ../src/AdActor.cpp -I../src -O2 -Wno-write-strings -Wno-conversion-null `freetype-config --cflags` `sdl2-config --cflags` -I/usr/local/include/bass/ 

In file included from ../src/PlatformSDL.h:31,

                 from ../src/dcgf.h:61,

                 from ../src/AdActor.cpp:26:

../src/dctypes.h:40:14: error: 'wstring' in namespace 'std' does not name a type

 typedef std::wstring WideString;

              ^~~~~~~

../src/dctypes.h:40:9: note: 'std::wstring' is defined in header '<string>'; did you forget to '#include <string>'?

../src/dctypes.h:32:1:

+#include <string>

 #include <string>

../src/dctypes.h:40:9:

 typedef std::wstring WideString;

         ^~~

../src/dctypes.h:43:19: error: 'WideString' was not declared in this scope

 typedef std::list<WideString> WideStringList;

                   ^~~~~~~~~~

../src/dctypes.h:43:19: note: suggested alternative: 'Utf8String'

 typedef std::list<WideString> WideStringList;

                   ^~~~~~~~~~

                   Utf8String

../src/dctypes.h:43:29: error: template argument 1 is invalid

 typedef std::list<WideString> WideStringList;

                             ^

../src/dctypes.h:43:29: error: template argument 2 is invalid

../src/dctypes.h:46:21: error: 'WideString' was not declared in this scope

 typedef std::vector<WideString> WideStringArray;

                     ^~~~~~~~~~

../src/dctypes.h:46:21: note: suggested alternative: 'WideStringList'

 typedef std::vector<WideString> WideStringArray;

                     ^~~~~~~~~~

                     WideStringList

../src/dctypes.h:46:31: error: template argument 1 is invalid

 typedef std::vector<WideString> WideStringArray;

                               ^

../src/dctypes.h:46:31: error: template argument 2 is invalid

In file included from ../src/dcgf.h:171,

                 from ../src/AdActor.cpp:26:

../src/BFontTT.h:43:3: error: 'WideString' does not name a type; did you mean 'FT_String'?

   WideString m_Text;

   ^~~~~~~~~~

   FT_String

../src/BFontTT.h:98:18: error: 'WideString' does not name a type; did you mean 'FT_String'?

   TextLine(const WideString& text, int width)

                  ^~~~~~~~~~

                  FT_String

../src/BFontTT.h:104:9: error: 'WideString' does not name a type; did you mean 'FT_String'?

   const WideString& GetText() const { return m_Text; }

         ^~~~~~~~~~

         FT_String

../src/BFontTT.h:107:3: error: 'WideString' does not name a type; did you mean 'FT_String'?

   WideString m_Text;

   ^~~~~~~~~~

   FT_String

../src/BFontTT.h:139:21: error: 'WideString' does not name a type; did you mean 'FT_String'?

  int WrapText(const WideString& text, int maxWidth, int maxHeight, TextLineList& lines);

                     ^~~~~~~~~~

                     FT_String

../src/BFontTT.h:140:25: error: 'WideString' does not name a type; did you mean 'FT_String'?

  void MeasureText(const WideString& text, int maxWidth, int maxHeight, int& textWidth, int& textHeight);

                         ^~~~~~~~~~

                         FT_String

../src/BFontTT.h:142:27: error: 'WideString' does not name a type; did you mean 'FT_String'?

  void PrepareGlyphs(const WideString& text);

                           ^~~~~~~~~~

                           FT_String

../src/BFontTT.h:145:39: error: 'WideString' does not name a type; did you mean 'FT_String'?

  CBSurface* RenderTextToTexture(const WideString& text, int width, TTextAlign align, int maxHeight, int& textOffset);

                                       ^~~~~~~~~~

                                       FT_String

../src/BFontTT.h: In constructor 'CBFontTT::CBCachedTTFontText::CBCachedTTFontText()':

../src/BFontTT.h:55:4: error: 'm_Text' was not declared in this scope

    m_Text = L"";

    ^~~~~~

../src/BFontTT.h:55:4: note: suggested alternative: 'm_Rect'

    m_Text = L"";

    ^~~~~~

    m_Rect

../src/BFontTT.h: In constructor 'CBFontTT::TextLine::TextLine(const int&, int)':

../src/BFontTT.h:100:4: error: 'm_Text' was not declared in this scope

    m_Text = text;

    ^~~~~~

../src/BFontTT.h:100:4: note: suggested alternative: 'm_Rect'

    m_Text = text;

    ^~~~~~

    m_Rect

gmake: *** [obj/AdActor.o] Error 1

Is this one of those c++11 (or higher) errors (which are not or only partly supported yet) or do i need to adapt the source in one way or another?

Using gcc 8.1.0 here

--

game box/art scans
scummvm infrequent builds

NoCache

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/13 14:15 #2

Just popping in

@Raziel

I think it is great idea, I will also find it handy
That wstring issue... I'm also dealing with it at the moment in one project, but no solution so far

kas1e

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/13 14:27 #3

Home away from home

@Raziel
Wstring stuff is about unicode wide characters (which half implemented if i remember right). So to make it works you can do as Alfkil do for his QT port:


namespace std

{

typedef basic_string<wchar_t> wstring;

}

Cant say how good that hack is, but probably all will works fine except parts where some non-standard text characters will be used in some text.

Join us to improve dopus5!
AmigaOS4 on youtube

LiveForIt

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/13 16:14 #4

Home away from home

@Raziel

If your have "using namespace std; "

Then the following lines, is assumed that is inside std namespace, so you do not need "std::" in the typedef, because it know it's this you're talking about.

So it should be fine to do:

typedef string AnsiString;
typedef string Utf8String;
typedef wstring WideString;

(NutsAboutAmiga)

Basilisk II for AmigaOS4
AmigaInputAnywhere
Excalibur
and other tools and apps.

tekmage

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/13 16:32 #5

Just popping in

I've always wanted to know what to do about a program that calls fork().

It's a basic POSIX thing that we don't have on the Amiga.

Thanks!
Bill "tekmage" Borsari

LiveForIt

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/13 16:36 #6

Home away from home

@tekmage

fork() is Linux kernel thing, it's not posix thing. use pthreads or threads in C++11.

the thing to do is look for Windows workaround for it, as its not supported in windows as well.

(NutsAboutAmiga)

Basilisk II for AmigaOS4
AmigaInputAnywhere
Excalibur
and other tools and apps.

Capehill

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/13 18:44 #7

Just can't stay away

@LiveForIt

Sure? http://man7.org/linux/man-pages/man2/fork.2.html

"POSIX.1-2001, POSIX.1-2008, SVr4, 4.3BSD."

Capehill

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/13 18:52 #8

Just can't stay away

@tekmage

Which program you are referring to?

Thematic

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/13 22:54 #9

Quite a regular

fork()'s so POSIX

I read that as "any program that calls fork()".

--

Suggestions for this sort of thing? to_string doesn't seem to be in std


#include <string>



    int main()

    {

        std::to_string(0);

        return 0;

    }

Edited by Thematic on 2019/2/14 0:57:56

Hans

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/14 4:00 #10

Home away from home

@Thematic

Quote:

Suggestions for this sort of thing? to_string doesn't seem to be in std

You need C++11 for std::to_string() (see here. So add -std=c++11 or -std=gnu++11 to the compiler's command line parameters. You may also need to use a newer version of GCC.

Hans

Join Kea Campus' Amiga Corner and support Amiga content creation
https://keasigmadelta.com/ - see more of my work

Thematic

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/14 7:02 #11

Quite a regular

@Hans
gcc is 8.1.0. I've tried lots of things. Even with space marines it won't make any difference.

Hans

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/14 7:16 #12

Home away from home

@Thematic

Oops! I forgot that I also tweaked one of the header files. Details are here (down the bottom). Switching to clib2 may also work, although you may find that other functions are missing then.

Hans

Join Kea Campus' Amiga Corner and support Amiga content creation
https://keasigmadelta.com/ - see more of my work

kas1e

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/15 12:31 #13

Home away from home

@Thematic
Alternatively, if you do not want to touch system headers as Hans show, you can do some workaround like we do in Barony:


#ifdef __amigaos4__

    char buff[50] = {0};

    sprintf(buff, "savegames/savegame%d", saveIndex);

    std::string filename = buff;

#else

    std::string filename = "savegames/savegame" + std::to_string(saveIndex);

#endif

Join us to improve dopus5!
AmigaOS4 on youtube

Raziel

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/15 20:58 #14

Home away from home

@kas1e

Thank you, that workaround did the trick.

@Liveforit

Unfortunately that fix doesn't work.
The error changes and the suggested fix does too, but it still breaks.

--

game box/art scans
scummvm infrequent builds

salass00

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/16 6:54 #15

Just can't stay away

@Raziel

An alternative fix for missing std::to_string and std::wstring.


#ifdef __amigaos4__

namespace std {

    template <typename T> string to_string(const T &n) {

        ostringstream strm;

        strm << n;

        return strm.str();

    }



    typedef basic_string<wchar_t> wstring;

}

#endif

Raziel

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/16 7:28 #16

Home away from home

@salass00

Thank you, works too.

This will hopefully become a nice lookup thread for common (porting) problems.

--

game box/art scans
scummvm infrequent builds

Raziel

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/16 17:12 #17

Home away from home

Next issue...i tried to build (after a year long hiatus) ScummVM with SDL1 (for test cases), but i get a linker error


LINK     scummvm

backends/platform/sdl/sdl.o: In function `OSystem_SDL::setupGraphicsModes()':

backends/platform/sdl/sdl.cpp:721: undefined reference to `SdlAudioCDManager::SdlAudioCDManager()'

gmake: *** [scummvm] Error 1

which is strange, because everything else is picked up correctly and i have the latest SD1 installed

--

game box/art scans
scummvm infrequent builds

BSzili

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/16 18:39 #18

Quite a regular

SDL is written in C, so the SdlAudioCDManager class probably belongs to ScummVM.

This is just like television, only you can see much further.

Raziel

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/16 19:28 #19

Home away from home

@BSzili

So, it might be a missing #include in the ScummVM code?

--

game box/art scans
scummvm infrequent builds

Thematic

Re: Porting to AmigaOS4 thread

Posted on: 2019/2/16 20:36 #20

Quite a regular

@Raziel

I think missing includes are caught in compilation, unless something weird was attempted maybe? Linking undefined reference suggests missing library, which is all too common. For instance library a could depend on library b, so -la is not enough. Also the order they are in the command line may make a difference.

I learned half the things from this http://www.os4depot.net/index.php?fun ... ment/manual/spots-pfd.lha

Register To Post	(1) 2 3 4 ... 22 »
	Top Previous Topic Next Topic

Currently Active Users Viewing This Thread: 4 ( 0 members and 4 Anonymous Users )