Horny Source code on Github

and stack trace from debug...
Is it enough?


Stack trace:
native kernel module newlib.library.kmod+0x0003058c
[Einstellungen.c:929] HornyOS4.debug:KontrolleEinstellungsfenster()+0xab4 (section 1 @ 0x1D804)
[Start.c:221] HornyOS4.debug:main()+0x94 (section 1 @ 0x5545C)
native kernel module newlib.library.kmod+0x000020ac
native kernel module newlib.library.kmod+0x00002d14
native kernel module newlib.library.kmod+0x00002ef0
HornyOS4.debug:_start()+0x170 (section 1 @ 0x16C)
native kernel module dos.library.kmod+0x000255c8
native kernel module kernel+0x0003e7b4
native kernel module kernel+0x0003e7fc

@mr2

Debug version needs there only for get right crashlog with poining out on line where it crashes. But you figured that out already :)

It crashes there then:



Crashed line are strncpy(lied.phonolithprojekt, str, 1024); , so someone with good coding skills need to fix that. Imho its all about the same issue about which gcc warn us before, just there it happens in another place, but all related to size of buffers probably.

@kas1e

Is the code correctly pasted? It seems a little bit strange with all that reduntant things.

Anyway, check that "str" is a valid pointer before strncpy.

Also If "str" points to a string that is longer than 1023 characters, there will not be NUL termination.

@Capehill
In case you in interst to see latest code, there is:
https://github.com/kas1e/midi-sequence ... gaos/tree/master/HornyGCC

@kas1e

I guess it's fine. Better some activity than nothing.
I just accepted the pull request, so your changes are "official" now ;)

@kas1e

Tested the new 1.4 beta
The program look interesting so I've Just done an italian translation for it, i will send you everything later so you can integrate it in repo.

Having noted a couple of bugs aswell

- The close button area is corrupted as soon as you start the program
Clicking somewhere with the mouse make this graphical glitch gone

See grab: http://tinyimg.io/i/jpIEF2a.jpg

- Got a DSI crash while i was exploring the functionality via menu ... i will give you the "how to reproduce" steps as soon as i will catch again

- I'm not able to play the example files that we can found in old version 1,3, it said that such midi were created with an old version, then it opened the file in some way, but pressing play doesn't reproduce any sound

Maybe in the conversion from BYTE to uint8 etc. there was a mistake and now the structs to load project files aren’t compatible anymore. This should be easy to fix.

@Capehill

Quote:
Yep. That could be a problem if it's NULL.

Quote:
That's a good reason to switch to more modern "strlcpy". It always terminates the copy with a NULL.
Maybe something like:
strlcpy(lied.phonolithprojekt, str, sizeof(lied.phonolithprojekt)); (https://linux.die.net/man/3/strlcpy)

Since "lied.phonolithprojekt" appears in a number of program files, it might be a good idea to initialize it in the structure declaration with something like "unnamed project".

@kas1e

Ok, here the italian translation:

http://s000.tinyupload.com/index.php?file_id=21900347574274025284

Can you upload in the github repo ?

And about the DSI crash i can reproduce:
It happens quite frequently when you try to open the "SysEx Manager" menu

------------------------------
Crash log for task "HornyOS4"
Generated by GrimReaper 53.19
Crash occured in module intuition.library.kmod at address 0x01AEB4E0
Type of crash: DSI (Data Storage Interrupt) exception
Alert number: 0x80000003

Register dump:
GPR (General Purpose Registers):
0: 01AEB4D8 57BED660 00000000 00000001 589416D6 00000000 0000001C 57BED6D8
8: 00000007 0000000B 00000000 000000CA 40422444 57BC7328 54ADB5B0 02280000
16: 54AE8430 8003002B 57BED9B0 540CD8DC 5FF724D0 80030009 8003002A 15540015
24: 54AE79CC 57BED678 5FF724D0 02280000 57BED73C 155401EB 54AE79CC 54AFDFA0


FPR (Floating Point Registers, NaN = Not a Number):
0: nan 410 322 0
4: 0 724.8 30.8 0
8: 0 4.5036e+15 724.8 30.8
12: 1135 353 0 -0
16: 1.32625e-315 0 0 0
20: 0 0 0 1.61895e-319
24: 0 0 2.65249e-315 0
28: 0 1.35808e-312 1.3581e-312 -0.25

FPSCR (Floating Point Status and Control Register): 0x82004000


SPRs (Special Purpose Registers):
Machine State (msr) : 0x0002F030
Condition (cr) : 0x54046DA0
Instruction Pointer (ip) : 0x01AEB4E0
Xtended Exception (xer) : 0x018233AC
Count (ctr) : 0x00000000
Link (lr) : 0x00000000
DSI Status (dsisr) : 0x01842B34
Data Address (dar) : 0x00000000



680x0 emulated registers:
DATA: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
ADDR: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
FPU0: 0 0 0 0
FPU4: 0 0 0 0



Symbol info:
Instruction pointer 0x01AEB4E0 belongs to module "intuition.library.kmod" (HUNK/Kickstart)

Stack trace:
native kernel module intuition.library.kmod+0x00087460
native kernel module intuition.library.kmod+0x00087458
native kernel module intuition.library.kmod+0x0002146c
native kernel module intuition.library.kmod+0x000215ec
native kernel module intuition.library.kmod+0x0000a348
native kernel module intuition.library.kmod+0x0000a0dc
native kernel module intuition.library.kmod+0x000316f4
native kernel module intuition.library.kmod+0x00013dec
native kernel module intuition.library.kmod+0x00014140
native kernel module intuition.library.kmod+0x0006ce38
native kernel module intuition.library.kmod+0x00021448
native kernel module intuition.library.kmod+0x000215ec
native kernel module intuition.library.kmod+0x0006cae0
module HornyOS4 at 0x6FA01384 (section 5 @ 0x4E360)
module HornyOS4 at 0x6FA00D38 (section 5 @ 0x4DD14)
module HornyOS4 at 0x6F9E84A0 (section 5 @ 0x3547C)
module HornyOS4 at 0x6F9EA218 (section 5 @ 0x371F4)
module HornyOS4 at 0x6FA083DC (section 5 @ 0x553B8)
module HornyOS4 at 0x6FA08444 (section 5 @ 0x55420)
native kernel module newlib.library.kmod+0x000020ac
native kernel module newlib.library.kmod+0x00002d5c
native kernel module newlib.library.kmod+0x00002ef0
HornyOS4:_start()+0x170 (section 1 @ 0x16C)
native kernel module dos.library.kmod+0x000255c8
native kernel module kernel+0x0003e7b4
native kernel module kernel+0x0003e7fc

PPC disassembly:
01aeb4d8: 2f9d0000 cmpwi cr7,r29,0
01aeb4dc: 419e0028 beq- cr7,0x1AEB504
*01aeb4e0: 80bd0008 lwz r5,8(r29)
01aeb4e4: 2f850000 cmpwi cr7,r5,0
01aeb4e8: 419e001c beq- cr7,0x1AEB504

System information:

CPU
Model: AMCC PPC440EP V1.3
CPU speed: 799 MHz
FSB speed: 133 MHz
Extensions:

@samo79
You need to run the debug version of the program and provide the crash log using that version in order to show the the program function and line number of the crash. The normal version of the program has too much data stripped in order to make the program smaller.

@All
So, is anybody willing to fix those bugs? I can from my side handle all the shit like giving you latest code in archive, then you send somewhere fixes, and i upload them to github, etc.

Even bug by bug will be fine.

Please please please!!!!

Wow.
I go away for a couple days of overtime, and it looks like I missed the party!

It's interesting that kas1e gets different compile issues. I didn't expect that.

I'm sure the CAMD cluster code can be improved. I am happy to do it, but finding enough time to do it might not be easy.

I have not even had time to play with it yet. I'm not sure when I will either. But it's always good to see MIDI activity on the Amiga. I'll try to keep an eye on this forum in case I can help, but there might be a couple days delay when I get busy at work.

This is all good news. :)
LyleHaze

Anyone to look on these issues?

@samo79

run the debug version as asked, and report the grim again with debug symbols, then maybe some one will fix this.

@kas1e

Forked the original repo and fixed (?) a couple of compiler warnings and potential NULL pointer issue. I haven't really tested those changes, other than binary starts.

Check here if interested: https://github.com/capehill/midi-seque ... 58639f1e034acb4f00f449063

I will need to get a USB-MIDI connector, it would be nice to try this tool.

German makes this project extra hard :D

@Capehill
At least your version compiles warnings free, and the same runs fine as before. So if you can, plz pull this changes back to Timo

@All
And there is version build with Capehill's changes:

http://kas1e.mikendezign.com/aos4/horny/Horny_test2.zip

Probably it should fix bug mr2 have, but bug which have Samo i can't reproduce, and he still didn't run debug version of it to give us normal stack trace. So, pretty possible it still there.

@kas1e

I'm still trying to reproduce it by using your new debug binary
Manwhile please upload my translation to github repo

@kas1e

Nope...

Crash log for task "HornyOS4.debug"
Generated by GrimReaper 53.19
Crash occured in module newlib.library.kmod at address 0x01B22B44
Type of crash: DSI (Data Storage Interrupt) exception
Alert number: 0x80000003

Register dump:
GPR (General Purpose Registers):
0: 80808080 51C97C00 00000000 50B71770 56011850 00000080 51C97C30 00000000
8: 50B71770 03000000 56011850 54696D69 000007C8 51CB0328 00000000 54E71680
16: 6F8B3390 00000000 5276A010 51C7BB98 02270000 02270000 00000000 00000001
24: 5FFF9300 00000001 46444888 00000000 02270000 02270000 51C7BB70 51C97C00


FPR (Floating Point Registers, NaN = Not a Number):
0: nan 531 514 0
4: 0 455.8 27.8 0
8: 0 4.5036e+15 455.8 255
12: nan 65536 0 2.43131e-295
16: 4.23878e-270 0 0 0
20: 0 0 0 0
24: 0 2.65249e-315 0 0
28: 0 0 9.88131e-324 5.58066e-222

FPSCR (Floating Point Status and Control Register): 0x82000000


SPRs (Special Purpose Registers):
Machine State (msr) : 0x0002F030
Condition (cr) : 0x51525DA0
Instruction Pointer (ip) : 0x01B22B44
Xtended Exception (xer) : 0x018233AC
Count (ctr) : 0x00000000
Link (lr) : 0x00000000
DSI Status (dsisr) : 0x01842B34
Data Address (dar) : 0x00000000



680x0 emulated registers:
DATA: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
ADDR: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
FPU0: 0 0 0 0
FPU4: 0 0 0 0



Symbol info:
Instruction pointer 0x01B22B44 belongs to module "newlib.library.kmod" (HUNK/Kickstart)

Stack trace:
native kernel module newlib.library.kmod+0x000305a4
[Einstellungen.c:834] HornyOS4.debug:KontrolleEinstellungsfenster()+0x38c (section 1 @ 0x1D0B4)
[Start.c:221] HornyOS4.debug:main()+0x94 (section 1 @ 0x55400)
native kernel module newlib.library.kmod+0x000020ac
native kernel module newlib.library.kmod+0x00002d14
native kernel module newlib.library.kmod+0x00002ef0
HornyOS4.debug:_start()+0x170 (section 1 @ 0x16C)
native kernel module dos.library.kmod+0x000255c8
native kernel module kernel+0x0003e7b4
native kernel module kernel+0x0003e7fc

@mr2
Crash happens the same? I mean the same way to reproduce? It's again strncpy with null-pointer, just in another place:



Crashes on "strncpy" line.

Should be probably changed on:

Quote:

There is new version with that change:

http://kas1e.mikendezign.com/aos4/horny/Horny_test3.zip

Try it plz.