Odyssey 1.23 progress: r5 RC2

@Petrol
Checked that ULONG thing you ask before edit your post : nope, that not it as well.

As for WritePixelArrayAlpha(), graphics.library didn't have such function, so it can't be mixed.

But yes, its all feels something about alpha/colors changes when we use png1.6 instead of 1.2. And it leave some artefacts like it works, just nothing visibly.

See on that video https://youtu.be/zYRl5QBCo8U

There one odyssey at bottom with old libpng (see compas animatino works) and one at top with new libpng (instead of compas, there just a dots). But images sure loads, i can see it from snoopy.

EDIT: I think what we see on video it just "fallback" mode. See in those files i point out :



So maybe we not in if(data->surface) now by some reassons, and fallback to built in animation (those small dots). And "throbber.cpp" file looks very much as those dots i have now.

@nbache

Quote:With the second beta, it looks like my crashes using the Unread/New buttons on Amiga.org is gone! At least I haven't seen it happen since I upgraded.

Also, it seems in general more stable and faster than ever.

Good job!

Best regards,

Niels

@kas1e

Well well, ok i know too much problems at once .. but probably this time i have found a big one

Latest beta version have problem to download things, maybe again because curl or don't know what

- Transifex website doesn't load anymore the strings to translate, the page remained blank

- Download button with certain website doesn't work anymore, for example try to download Inviyya game by pressing the red button

https://tigerskunk.itch.io/inviyya

Both sites have problem with latest r5 beta_02, but works fine with stable official version of odyssey .. i fear in end will be forced to revert a library

@samo79
Try to unpack beta02 to ram, and then retestest everything again.

Quote:

All the libraries should be updated, because its the only way move forward, be it 1.25, or new core, or whatever else.

Try everything from RAM: , fresh unpacked beta02. Then if issue there, fresh unpack to RAM beta01 and try that one. You know how to test things i am sure :) And i shomehow sure you mess with spoofing options at night. And plz, at moment wait till other will read/help with PNG issues plz, as topic will be flooded.

@samo79Quote:
Did that and it downloaded just fine for me with Beta 02.

Filename:
inviyya_demo_v2.adf
Size:
901,120

@samo79

Tried too with R2 and auto downloads adf wirhout problem.

@All
About png issues with png-animation images when swapped from 1.2 to 1.6 its as i expect tomorrow: when we compile with 1.2, then we inside of "if(data->surface)". When compile with 1.6, then we have no data->surface there, and fallback to to builtin animation.

Now need to understand why. Interesting that it happens only with animation pngs, not with pure ones, all other pngs loads and shows fine.

I do search in whole odysseys code just on "if(data->surface)", to see if it used anywhere else and it used in 4 classes: 2 for animation (tabtransferanimclass.cpp and transferanimclass.cpp) and 2 for icons (faciconclass.cpp and iconclass.cpp). As icons in the tabs, and icons in the hotlinks are works, it mean that "data->surface" thing works with libpng1.6, just by some reassons fail for those 2 anim classes.

Any ideas ?:)

The things i change in the Odyssey's code to compile it with 1.6, its only there (see commented at end of 2 strings, that what i added for 1.6):


https://github.com/kas1e/Odyssey/blob/ ... NGImageDecoderWK.cpp#L318

So for 1.2 its:

Quote:

And for 1.6 its:

Quote:

But then i even use the 1.6 way, and compile with 1.2png (and 1.2 includes, no 1.6 of course), and it also works. So if something to blame, its new png includes differences and/or classes itself.

EDIT2: i also checked today's webkit code and they use the same way for 1.6 build. It seems that issue can be inside of amiga-mui code, as png-decoder seems almost the same in today's webkit. At least in that png-decoder part.

Maybe something should be also changed in cairo parts of odyssey code ..

EDIT3: I added more debug printfs to the "DEFNEW" function of one of animation classes there: https://github.com/kas1e/Odyssey/blob/ ... ransferanimclass.cpp#L100

And when i compile with includes/lib from 1.2, then i go inside of "if(cairo_surface_status(data->surface) == CAIRO_STATUS_SUCCESS)". But when i compile with 1.6, then i go to "else", so fallback later in DEFMMETHOD(Draw) to default animation, as no data->surface of course.

By some reassons with 1.6 we have !=CAIRO_STATUS_SUCCESS. Maybe cairo_image_surface_create_from_png fail somehow

@kas1e
...
without knowing nothing about caire/libpng,...

What does "cairo_surface_status(data->surface)" return, instead of _SUCCESS?

@Jabirulo
It can return lot's of things, and i think i come close already, it's "cairo_image_surface_create_from_png()" function fail.

Cairo we use currently pretty old : v1.12.16 , very possible it just this function have issues when used together with 1.16.

I also do some google, and find there were some patches to cairo because of libpng16. Maybe that not related, but imho very close.

As for return types, i just do:

Quote:

And have when compiled with libpng16 "NO_MEMORY" , while with libpng12 "SUCCESS".

Now need to check Cairo's changelogs, how much of changes there were in cairo-png.c since 1.12.16


But at least i find that patch: https://bugs.freedesktop.org/attachment.cgi?id=77910

So maybe that it, will try to rebuild my cairo with that path too.

@kas1e

Yep, that was other of my thoughts, that maybe our cairo is a bit too old for libpng16

Hope such patch solves/fixes it.

@Jabirulo
I just recompile version of cairo we use with png16 together with odyssey itself, and then it works, yahoo!

One bug less ;)
Good job!

@kas1e

YESSssssssssss, GREAT JOB MAN!!!!

@all

http://kas1e.mikendezign.com/aos4/ody ... odyssey_1.23r5_beta03.lha

Odyssey 1.23 r5_beta03 - AmigaOS4

-- fixed bug in Odyssey with WebP rendering being in blue color (Cairo expect ARGB, no needs for byteswap) (c) Petrol. Also, rebuild with newer libWebP v1.1.0
-- major PNG decoding changes:
1). Odyssey compiled with 1.6.37 instead of old 1.2.50 libpng + necessary changes in Odyssey's code
2). added APNG (animated png) support. Code taken from today's WebKit source code and adapted to our version + added .apng mime-type as well.
Changes applied:
https://trac.webkit.org/changeset/181553/webkit
https://trac.webkit.org/changeset/194503/webkit
For test visit https://en.wikipedia.org/wiki/APNG and see if animation works
-- Ouch! The current version of Cairo we use till now didn't use Semaphores as expected, but pthreads instead ! Removed pthreads usage in favor of os4 semaphores.
That theoretically can bring some speed and may have some impact on MediaPlayer. Also recompiled Cairo with libpng16 as well (but it still old version of cairo, some more work should be done before updating it)
-- actual build dates for $VER: everywhere (version, aboutbox, and about.html)
-- fix "download-font" script by adding --no-check-certificates to wget (c) khayoz


All updates are on github, so if morphos guys will be not that stubborn they can just copy+paste apng related parts. Probabaly if they have issues with webp then our fix can fits into to. Updated not only odyssey's code, but also SDK (new cairo lib/includes, new libpng lib/includes), so if you will build things from github, then SDK update are must and whole rebuild of whole Odyssey from scratch are must 100% (as it use cairo in all the places, and if you will keep old objects compiled with old cairo includes, it will then bring all sort of bugs). So fresh full recompilation with whole update of SDK are must.

@kas1e

Really good job. Animation working without any problem !

@kas1e
Quote:
Very nice. Thanks for all the work!

Just did some quick testing of APNG's and webm videos. All worked quite well. Did a google search on animated PNG graphics and play many of the APNG files that came up in the search without any problems.

Found a couple of websites to test the embedded webm playback. The good old Buck Bunny embedded webm video can be found here:https://www.webmfiles.org/demo-files/

I also found a site that let's you change the embedded webm video resolution on the fly. Just click on the video and click the webm control at the bottom.
https://commons.wikimedia.org/wiki/File:Volcano_Lava_Sample.webm

360p plays great with the X1000. 480p starts to struggle a bit.
The Webm videos I tried so far seem to work great!
This sitle also allows switching to vp9 format and they play but they are much more prossesor intensive so the sound can get lost.

@kas1e
Can i just replace the new version over the older one?

@JoeledQuote:
I tried that and received a lot of crashes. I then kept beta3 on its original directory and copied the key preferences files over from beta2 and it runs very stable. Even playing a lot of videos.

@joeled
Better fresh install all the time, that will save us from all kind of possible issues which may happens because of different lbraries and their new/old config files. Different fontconfig caches, .db files, fonts libs, and co, everything can be cause of issues. So fresh install is must.

@ktadd
In case with beta3 there was added new filetype/mimetype, so if you has for example some manually added things in prefs, then new binary may cause issues yep, as things shifts/changes. Better all the time fresh install for sure.

@kas1e

Would it be possible to upload your RC's to github instead?
That way it would be in it s central place and people wouldn't have to remember your personal webspace