Odyssey 1.23: AOS4 source code on GitHub

	Bottom Previous Topic Next Topic
Register To Post

« 1 2 3 4 (5)

kas1e

Re: Odyssey 1.23: AOS4 source code on GitHub

Posted on: 2020/3/27 9:54 #81

Home away from home

@Capehill
Quote:

Need to start fixing those compiler warnings, too ;)

Yes! There lot in gui code, i am sure fixing some of them will make some bugs disappear :) For example i don't like those warnings about all hooks. I.e.

Quote:

S/appclass.cpp:483:92: note: in definition of macro ‘REXXHOOK’
#define REXXHOOK(name, param) static const struct Hook name = { { NULL, NULL }, (HOOKFUNC)&Rexx, NULL, (APTR)(param) }
^~~~
/amiga/Odyssey/odyssey-r155188-1.23/Source/WebKit/OrigynWebBrowser/Api/MorphOS/appclass.cpp:483:92: warning: cast between incompatible function types from ‘LONG (*)(Hook*, Object*, IPTR*)’ {aka ‘long int (*)(Hook*, long unsigned int*, long unsigned int*)’} to ‘HOOKFUNC’ {aka ‘long unsigned int (*)()’} [-Wcast-function-type]

Probabaly some cast should be enough , but it will fix lot of warnings output, as it as for one hook it can bring up to 20 warnings where it used.

Join us to improve dopus5!
AmigaOS4 on youtube

Capehill

Re: Odyssey 1.23: AOS4 source code on GitHub

Posted on: 2020/3/27 12:28 #82

Just can't stay away

@kas1e

Yeah, those hooks. It seems that C++ is more picky in function pointer casts than C. I have the same issue in some of my projects - (HOOKFUNC) gives warnings in C++. If someone has a solution, it would be nice to hear.

kas1e

Re: Odyssey 1.23: AOS4 source code on GitHub

Posted on: 2020/3/27 13:04 #83

Home away from home

@Capehill
Another commit: this time remove dependency on libaos4deps.a (which contain stccpy() and DoSuperNew()), now i made them as one more object file, so no needs for custom libaos4deps.a anymore.

Next is probably we need to get rid of -lauto, just so things are cleaner ?

Quote:

Yeah, those hooks. It seems that C++ is more picky in function pointer casts than C. I have the same issue in some of my projects - (HOOKFUNC) gives warnings in C++. If someone has a solution, it would be nice to hear.

At least i found how to case to hide the warning, through do not know how correct is it. I.e. instead of:

Quote:

#define REXXHOOK(name, param) static const struct Hook name = { { NULL, NULL }, (HOOKFUNC)&Rexx, NULL, (APTR)(param) }

It's

Quote:

#define REXXHOOK(name, param) static const struct Hook name = { { NULL, NULL },(HOOKFUNC)(LONG*)&Rexx, NULL, (APTR)(param) }

Warning gone then, links fine, but have doubts if it correct way and if all works at all as expected :)

Join us to improve dopus5!
AmigaOS4 on youtube

salass00

Re: Odyssey 1.23: AOS4 source code on GitHub

Posted on: 2020/3/27 13:27 #84

Just can't stay away

@kas1e

Try replacing the "(HOOKFUNC)" cast with "(APTR)". This works for C code at least.

kas1e

Re: Odyssey 1.23: AOS4 source code on GitHub

Posted on: 2020/3/27 15:34 #85

Home away from home

@salas00
APTR even bring not warning, but -fpermissive error:

Quote:

error: invalid conversion from ‘APTR’ {aka ‘void*’} to ‘uint32 (*)()’ {aka ‘long unsigned int (*)()’} [-fpermissive]
#define REXXHOOK(name, param) static const struct Hook name = { { NULL, NULL }, (APTR)&Rexx, NULL, (APTR)(param) }

Join us to improve dopus5!
AmigaOS4 on youtube

salass00

Re: Odyssey 1.23: AOS4 source code on GitHub

Posted on: 2020/3/27 18:55 #86

Just can't stay away

@kas1e

In that case use "(HOOKFUNC)(APTR)&Rexx".

kas1e

Re: Odyssey 1.23: AOS4 source code on GitHub

Posted on: 2020/3/27 20:27 #87

Home away from home

@Salas00
Yeah, that one works, thanks!

Join us to improve dopus5!
AmigaOS4 on youtube

jabirulo

Re: Odyssey 1.23: AOS4 source code on GitHub

Posted on: 2020/3/28 17:10 #88

Just can't stay away

@kas1e

Did a new git clone (instead of a git pull) and recompile on my oooold dualcore intel machine, took some hours.
Everything went fine.
Just need to test build if it works ok on my SAM460ex

Great job guys!!!!

kas1e

Re: Odyssey 1.23: AOS4 source code on GitHub

Posted on: 2020/5/19 17:09 #89

Home away from home

@All
SDK and main code were updated on GitHub, so if one wants to build it, an update of SDK must as well as minimum data files required now in the beta07 archive there: http://kas1e.mikendezign.com/aos4/ody ... odyssey_1.23r5_beta07.lha

Join us to improve dopus5!
AmigaOS4 on youtube

ktadd

Re: Odyssey 1.23: AOS4 source code on GitHub

Posted on: 2020/5/19 17:18 #90

Quite a regular

@kas1eQuote:

SDK and main code were updated on GitHub, so if one wants to build it, an update of SDK must as well as minimum data files required now in the beta07 archive

Thanks for the new release. Anything new besides blanking the mouse pointer while full screen videos are playing?

Never mind. Just found the answer in the "Odyssey 1.23 Progress" thread.
Thanks!

Register To Post	« 1 2 3 4 (5)
	Top Previous Topic Next Topic

Currently Active Users Viewing This Thread: 2 ( 0 members and 2 Anonymous Users )