Shaderjoy 1.25

@kas1e

almost the same way i forwarded them to my OS4 machine.

Quote:

what about 2 folders? "Top Notch" and "Working". Maybe another person has different personal preferences and likes a specific shader more. Also good to have a whole bunch of all working shaders on OS4 (educational purposes or smt.).

@kas1e

Quote:

Hmm... I think I will wait for some days if there are more reports, before uploading to OS4Depot.

Between 1.1 and 1.2 there were some new bugs but also some fixes for them. By the way, please enable verbose logging and check prints at exit. For me, there is typically 40 kilobytes of stack used. You have different driver set so there could be some impact but probably not much.

@IamSonic
In end of all all shadertoy's should works :) And they mostly are, except that 1 bug causing noise which seems share quite a few shaders, another issue limited number of SGRPS and VGRPS , and just a bit of non-compiling ones. All of this should be fixed on our side, and in end all of them will works.

There also surely some bugs with colors in some shaders, and sometime with geometry, but in compare with amount of shaders checked (more than 1000 for now), amount of them not very big.

@Capehill
Are you use some stack cookie ? If so, maybe just set it to something like 0.5 mb , and so no problems ever will be , and no one will ever notice it :) Or at least 200kb or so.

@kas1e

about stack cookie: I will notice!!!!! too much cockie memory wasted!!!


Nice update Capehill!!! Keep the good work mate!!!

@jabirulo

Seeing verbose log, its already 1mb :) So issues i meet with surely not stack related.

@Capehill
Again crashed on exit. This time enable verbose only after shader works, so all i had in the console its "~Context", and then crash. There crashlog:



It's surely something new. v1.1 didn't have those crashes for sure, as i test it for hours with all sort of stuff.

EDIT: can reproduce it second time. Both time was with shader used textures (ichannel 0 and ichannel 1 at the same time), and then few resizing of window with VSYNC disabled, and pressing on close-gadget.

EDIT2: same shader with same steps didn't on v1.1 didn't crashes when press close gadget.


EDIT3: Now, i have a crash in v1.2 just when i load shader , then load 2 ichannels, and bah. Crashlog:



Ignore DSI helps this time (but weren't another time when i early have crash while do nothing and shader working)

@kas1e

Quote:

Could you send a link to this shader?

Stack cookie is set to 100000 bytes, so if your system has less then it is used, but if your system has more stack, then stack cookie is ignored.

@Capehill
It happens with different shaders, but easy to reproduse is "noise fire" with gray_noise_small texure (last link in yesterdays working ones, i am on phone so cant fast copy+paste)

edit: that one : Noise Fire : https://www.shadertoy.com/view/XlKyzW (iChannel0: Gray Noise Small)

Retested to be sure , and with 1.1 all fine 100%.

@kas1e

There is a bug related to close gadget handling: because window pointer is not cleared, application will try to do "one last render" before exit on a dangling window pointer. For some reason I haven't been able to reproduce the issue on my side.

I will provide a debug build with -O0, maybe that aligns the stack trace better, for the remaining problems.

@Capehill
Should to say that i got now bug with close gadget in v1.1 as well. I just tried to play with some small noise-test case, so all i do is change code via multiedit, and press "reload shader". At some point, shader fail to compile (so ok), then i press "reload" shader and nothing happens. Then i tried to close shaderjoy - nope, shaderjoy window didn't reacts

@kas1e

Please try this: http://capehill.kapsi.fi/shaderjoy/Shaderjoy-1.2-debug.lha

@Capehill
With 1.1 false alarm : i just didn't scroll buffer down, so window with "shader failed compile" didn't arise, and so close gadget didn't work because of that. Once move scrollbuffer back, window shoup and all closes.

Tested for now 1.2 debug, at moment can't reproduce, trying harder now

@Capehill
Reproduced!

@kas1e

Hmmmmm. According to code inside aglDestroyContext (and so forth). So I guess you are quitting the program or?

I cannot see why it crashes though, other than the obvious nullptr access.

@Capehill
Yes that one was when hit close button.

@Capehill
Another time crashes with 1.2 when just loading some shader which i load fine via 1.1 with textures and iresolutionchannel. This time crashes just in process when i just "load texture":

@kas1e

Addr2line gave me confusing results for the last stack trace. It looked like an exception was thrown and then suddenly code was in ogles2.library.

Anyway, 1.3 is up and it contains debug symbols, hence the large binary size. Changes:

- Add iDate support.
- Add verbose logging.
- Fix: window pointer is now cleared when close gadget is used.
- Keep textures (iChannels) active when switching shaders.

Ps. tested iDate with this clock shader: https://www.shadertoy.com/view/XddSRN

@Capehill
Seems that crash on exit gone. At least i can't reproduce it the same easy at moment as was with 1.2.

Also now can load firstly iChannel's textures and then shader and it works too as if i load firsly shader and then textures, cool !

And also iDate works indeed , i tested with that one and it works too (and looks good btw):

https://www.shadertoy.com/view/4lfSRM (ichannel0: lichen)

I sure you have enough to do already, but if you even will be at fullscreen implementation, can be nice to just "dbl-click" by mouse to swith to/from as well as alt+enter. Also for play/pause "space" button will be handy.

Will continue tests

@Capehill
Is shadertoy's textureLod() translated to OpImageSampleExplicitLod() when passing to ogles2/nova ? Why i ask that i have quite a few compile errors for shadertoy's shaders saying "OpImageSampleExplicitLod instruction isn't implemented yet" , but code of shader have textureLod() call.

@kas1e

Probably, if you compare to GLSL documentation:

"perform a texture lookup with explicit level-of-detail"

https://www.khronos.org/registry/OpenG ... gl4/html/textureLod.xhtml