How to allocate TimeRequest

	Bottom Previous Topic Next Topic
Register To Post

billyfish

Posted on: 2020/5/17 18:05 #1

Just popping in

Hi all

I'm trying to allocate a struct TimeRequest object and copying the code from the a2d.c example code from here, yet it fails to allocate the object using AllocSysObjectTags(). Is it something stupid that I'm doing??? I'm basically just after getting the ITimer interface so is there another way to do it?

cheers

billy


// a2d.c

#include <exec/types.h>

#include <exec/memory.h>

#include <dos/datetime.h>

#include <devices/timer.h>



// Note these three libraries are opened by newlib startup code.

#include <proto/exec.h>

#include <proto/dos.h>

#include <proto/utility.h>



#include <proto/timer.h>



struct TimerIFace *ITimer = NULL;



int main()

{

    struct TimeRequest *tr = IExec->AllocSysObjectTags(ASOT_IOREQUEST,

    ASOIOR_Size, sizeof(struct TimeRequest),

    ASOIOR_ReplyPort, NULL,

        TAG_END);



  if (tr != NULL)

  {

    if (!(IExec->OpenDevice("timer.device", UNIT_VBLANK, (struct IORequest *)tr, 0) ))

    {

            struct Library *TimerBase = (struct Library *) tr->Request.io_Device;

      ITimer = (struct TimerIFace*)IExec->GetInterface(TimerBase, "main", 1, NULL);



      if (ITimer != NULL)

      {

        struct TimeVal tv;

        ITimer->GetSysTime(&tv);



        IDOS->Printf("GetSysTime():\t%d %d\n", tv.Seconds, tv.Microseconds);



        struct ClockData clockdata;

        IUtility->Amiga2Date(tv.Seconds, &clockdata);



        IDOS->Printf("Amiga2Date():  sec %d min %d hour %d\n",

          clockdata.sec, clockdata.min, clockdata.hour);



        IDOS->Printf("               mday %d month %d year %d wday %d\n",

                    clockdata.mday, clockdata.month, clockdata.year, clockdata.wday);



        int32 seconds = IUtility->CheckDate(&clockdata);



        IDOS->Printf("CheckDate():\t%ld\n", seconds);



        seconds = IUtility->Date2Amiga(&clockdata);



        IDOS->Printf("Date2Amiga():\t%ld\n", seconds);



                IExec->DropInterface((struct Interface*)ITimer);

      }



      IExec->CloseDevice((struct IORequest *)tr);

    }



        IExec->FreeSysObject(ASOT_IOREQUEST, tr);

    }

    else

    {

        IDOS->Printf ("Failed to allocate TimeRequest\n");

    }



  return RETURN_OK;

}

Edited by billyfish on 2020/5/17 18:56:26

LiveForIt

Re: How to allocate TimeRequest

Posted on: 2020/5/17 18:22 #2

Home away from home

before TAG_END, you have "ASIOR", that must be edit error.

(NutsAboutAmiga)

Basilisk II for AmigaOS4
AmigaInputAnywhere
Excalibur
and other tools and apps.

salass00

Re: How to allocate TimeRequest

Posted on: 2020/5/17 19:00 #3

Just can't stay away

@billyfish

You must provide a valid message port for ASOIOR_ReplyPort. If it's NULL the allocation will fail, same as with CreateIORequest().

billyfish

Re: How to allocate TimeRequest

Posted on: 2020/5/17 19:00 #4

Just popping in

@LiveForIt

Sorry, when i pasted ito my post I accidentally added the ASIOR bit. I've edited the post to remove that. It compiles fine, but the timerequest allocation fails and I get the printf statement confirming it.

If I switch to allocating it with


struct TimeRequest *tr = IExec->AllocVecTags(sizeof(struct TimeRequest),

    AVT_ClearWithValue, 0,

    TAG_END);

and


IExec->FreeVec (tr);

it works fine. Anyone have any idea what I'm doing wrong with the AllocSysObjectTags() version?

cheers

billy

kas1e

Re: How to allocate TimeRequest

Posted on: 2020/5/17 19:14 #5

Home away from home

@billyfish

That how i allocate it in Odyssey (and it works of course):

https://github.com/kas1e/Odyssey/blob/ ... her/MorphOS/main.cpp#L392

Join us to improve dopus5!
AmigaOS4 on youtube

LiveForIt

Re: How to allocate TimeRequest

Posted on: 2020/5/17 19:18 #6

Home away from home

@billyfish

this is wrong " ASOIOR_ReplyPort, NULL, "

you need to provide a message port.

Create a port using "ASOT_PORT"
see "sdk:documentation/autodocs/exec.doc"

replace "NULL" with Port you created.

(NutsAboutAmiga)

Basilisk II for AmigaOS4
AmigaInputAnywhere
Excalibur
and other tools and apps.

billyfish

Re: How to allocate TimeRequest

Posted on: 2020/5/17 19:31 #7

Just popping in

@LiveForIt, @salass00 and @Kas1e

Thanks guys, I'll update the code. So the page at https://wiki.amigaos.net/wiki/Date_Functions needs to have the example a2d.c code fixed I guess.

cheers

billy

Edited by billyfish on 2020/5/18 11:45:38

colinw

Re: How to allocate TimeRequest

Posted on: 2020/5/21 8:17 #8

Just popping in

Watch out with using %d with IDOS->Printf(), it doesn't work.

All VARARGS68K arguments are padded to 32 bit wide and means
you should use (long) %ld formatter instead, no matter what the argument width is.

Same goes for even one byte arguments, you would use %lc instead of %c

billyfish

Re: How to allocate TimeRequest

Posted on: 2020/5/21 15:46 #9

Just popping in

@colinw

Thanks they're good bits to know. I'll post a bug report on Hyperion's forum so they can update the example at https://wiki.amigaos.net/wiki/Date_Functions.

cheers

billy

tonyw

Re: How to allocate TimeRequest

Posted on: 2020/5/22 0:54 #10

Quite a regular

@billyfish

The code on the wiki site looks OK to me. Are you sure you copied it all and didn't leave out some stuff?

Especially the need to create your own MsgPort before you call AllocSysObject() ?

cheers
tony

trixie

Re: How to allocate TimeRequest

Posted on: 2020/5/22 5:39 #11

Amigans Defender

@tonyw

Fredrik Wikstrom had updated the code before you looked

The Rear Window blog

AmigaOne X5000 @ 2GHz / 4GB RAM / Radeon RX 560 / ESI Juli@ / AmigaOS 4.1 Final Edition
SAM440ep-flex @ 667MHz / 1GB RAM / Radeon 9250 / AmigaOS 4.1 Final Edition

Templario

Re: How to allocate TimeRequest

Posted on: 2020/5/22 10:46 #12

Quite a regular

How complicated is the current C, since I learned Turbo C++.

Register To Post
	Top Previous Topic Next Topic

Currently Active Users Viewing This Thread: 2 ( 0 members and 2 Anonymous Users )