Horny Source code on Github

@kas1e

The same way to reproduce, yes.

You can try...Run Timi (soft synthesizer from Contribution on AOS4 FE CD)
Run Horny/Settings. You have to have empty MIDI cluster window. Then try to CHANGE output (cycle gadget) to Timi. Do it second time or try to close settings and bang!
If you use ADD button to add Timi to the cluster window everything is OK.

I will test as soon as I'm home :)

EDIT> Maybe a message 'you have to ADD sth before CHANGE' would be appropriate?

@kas1e

Quote:

Yes, it did the trick! Thanks

@mr2
Ok good !

@Capehill
Or i can just grab your changes, put in my repo, add the last fix for mr2's crash and put it in one commit to Timo's repo. What you think?

@kas1e

Sure, please go ahead.

@all
Added Capehill's fixes and my last one to forked repo: https://github.com/kas1e/midi-sequencer-amigaos/commits/master and made pull request to Timo, so once he accept it will be in main one.

I was in hope to enable "-Werror" now, but can't because of one single error which throw at me gcc 8.2.0:

Quote:

@kas1e

I worked it around, take a look at my patch, line 541 in Sequenzen.c.

I think you can compare my branch against your and pull the changes using github, in case you did it manually.

@Capehill
Oh you are right! Damn manual editing and just changed wrong line. Now all fine, and enable -werror by default too.

Will pull-request that one as well

ditto

@All
Pull request accepted, now all in official repo

@kas1e

Fixed one issue reported by CppCheck: https://github.com/capehill/midi-seque ... ac30299aa93b143bef0f9155f

Is Horny_test3.zip (28-Jan-2020) the latest binary?

@densho
Yes, nothing else done.

@kas1e

Ok, so no new radical changes in code after that.

Bugs with top-left dropmenu and scroll/resize bars are still there. Visually it looks like some of them are drawn in wrong coordinates ("0,0") in the main window. Drawing is probably handled differently in code but that what it looks like...

Also, sometimes I can summon large down arrow at top-left corner when clicking at the low-right area where scroll bar arrow should be. Just load any of the sample projects provided with Horny and try clicking the low-right area where arrows are missing.

So, anyone? :)

@densho

Quote:
I've looked into this, and after some testing I'm afraid I have bad news

The problem is not in the Horny code but in ReAction classes, namely the Slider Gadget and the Scroller Gadget. Somewhere between OS3.x and OS4.x the classes were changed apparently, and they can no longer get added to a traditional Intuition window, i.e. outside of a Layout Gadget group. This works fine in the OS3 version of the classes, hence no problems in the OS3 Horny version. But under OS4.1 the Slider does not display at all in an Intuition window, and the Scroller causes what Densho has described above. I've tested the classes in my own program, and the result is the same as in Horny.

There is a good deal of custom rendering going on in the main window and the Note Editor, so I guess it would be quite challenging to try and rewrite them to use a ReAction layout. (The fact that the program code contains no comments and everything - functions and variables - is in German doesn't make it any easier.) Therefore, our best bet would be to ask an OS4 developer to have a look at and, hopefully, fix the Scroller and Slider gadget classes.

I've recently asked Fredrik Wikstrom to fix a bug in the ClickTab Gadget, and he was kind to provide a quick fix (although God knows when this will be released). So maybe Fredrik is our man to get us Horny users - pun intended - out of trouble.

@trixie

Thanks for checking this. Using reaction gadgets outside of gadget group sounds like a not correct way to do it and maybe it was fixed in later reaction releases.

Fredrik, are you reading this? Or can you Trixie submit a bug report?

@densho

Quote:
Well, ReAction gadgets are BOOPSI gadgets, and Commodore's original BOOPSI system didn't have anything like the Layout Gadget. So the original BOOPSI gadgets were added to normal Intuition windows (there was no Window Class at that time, either).

Most ReAction gadgets, I think, technically don't need to be put in a layout group, but doing so brings so many advantages for your GUI programming that most developers use the Window Class / Layout Gadget combo. Perhaps this is why it escaped everyone's attention that at some point the Scroller and the Slider stopped displaying correctly when added to a traditional window.

Well, this is just a rhetorical exercise now because I am happy to report that Fredrik Wikstrom has fixed the problem in slider.gadget 53.17 and scroller.gadget 53.16. So we just need to hope that Hyperion has an OS update in store some time soon

@OS4 MIDI users
Fredrik has a DONATE button on his website www.a500.org, so why not show your appreciation by sending a small donation for his effort?

@trixie

Do we really have to wait for a update to get both gadgets? (

@sinisrus

In the past you'd get the updated gadgets over AmiUpdate in no time. Now that this policy was ditched we have to wait for an official OS update (myself included, as I'm not a betatester). I know it's crazy.

@sinisrus @trixie

Have waited 3 1/2 years for an X5000 update..
Wish they would let more ppl betatest Amiga OS4.X.

Asked Hyperion for an betatest N.D.A. , no response..

Asked A-Eon for an betatest N.D.A. , no response..

Latest OS4.1FE Update2 fixes the scrollbars and dropdown menus, just like Trixie mentioned - very nice :)

Small donation sent to Frederic for fixing this, I suggest others do the same.

There are small drawing issues still, but these are not showstoppers:




Above happens when you load sample project and zoom the horizontal view, and depending windows size those black likes are drawn to scrollbar and window border.