Redeclaration error

I remember having a similar error, but I cannot find the thread or notes where it got fixed or worked around, so...please advise

Thanks in advance

@Raziel
https://os4coding.net/forum/how-avoid- ... iables-conflicts-best-way

In brief, if it c++, then use -D__USE_AMIGAOS_NAMESPACE__ when compile source.

If it C, then the only solution is to rename those conflicting names in your code (like finding out in all the files where the word "Image" happens to be and rename it to something else like "_Image"). Alternatively, as Salas00 says in the second post of the thread I pointed out: avoid including AmigaOS includes in such files that have these conflicting definitions. But that IMHO harder in comparison with just renaming all "Image" words on "_Image".

@Raziel

You can probably edit mgl/context.h and comment out #include for intuition.h. It's a hack but I don't see a reason for this include to be here.

Thank you both, will try and report back once I'm home again

Is there a list and description of the possible defines somewhere?

@Raziel
There no list, because it probably makes no sense to create, as it depends on what name of structures used in the code you try to port.

I.e. "Image" structure pretty often used (as it is logical), and this one also used in our SDK too => conflicts, you had to rename it.

also "Screen", "Point" i.e. everything one may want to use in his project, and which also AmigaOS may have.

That all happens not very often, but if happen, you can see the name of the conflicting structure from error log.

Probably the easier way will be as Capehill points out: comment out intuition include in minigl includes, and if that didn't help, then ask ScummVM coders to maybe rename Image to something like _Image. And if they will keep silent about, then just rename it locally on your build

@kas1e

K, thanks.

I'll try with your solution first, should be easy to do as scummvm is using defines in it's code too.

Is there a -D__AMIGAOS_SHAREDLIBS__ define?
There is one in morphos (-D__MORPHOS_SHAREDLIBS__).

And if there is, what does it do?

@Raziel
__MORPHOS_SHAREDLIBS is a convenience macro that allows you to use certain shared libraries (jfif.library, png.library, z.library etc.) as drop in replacements for static variants (e.g. libjpeg.a, libpng.a libz.a). Otherwise the SDK headers will include_next the user's headers.

@BSzili

Thank you, sir

@kas1e

Your define didn't help.
It just brings up more errors of the same kind, but this time as early as in the amiga files (pLock, IDOS etc.)

@Capehill

Editing mgl/context.h did the trick.

Thank you.

Would it be worth to check if this include needs to be there at all and remove it from the code?

In any way i'll take a note if i ever hit this kind of problem again.

Thank you very much

@Raziel

It's possible that include is there for compiling the MiniGL library itself. But again, since it seems that nothing in context.h itself requires including intuition.h, it would be better to move include to .c files rather, IMHO.

@Raziel

I also tried the mgl/context.h trick. That compiles but crashes starting ScummVM, certainly due to missing hardware support in MiniGL (I switched to a RadeonSI board and don't have Warp3D_SI drivers yet).
I remember months ago I tried to play with namespaces and that was not satisfying. I don't remember well problems I faced at that time but that implied to modify system and MiniGL includes if I remember well.

With your last release of ResidualVM (thanks for that), I get an error ("OpenGLGraphicsManager::endGFXTransaction: Could not load any graphics mode!") but that does not crash.

Note that I compiled ScummVM with SDL1.2 ... I have to install SDL2.0 libs and includes in my SDK.

I wanted to compile the latest version of MiniGL with the removed Intution include but I got an error about the SVN client being too old.

@corto

There was an SVN update some time ago: https://sourceforge.net/projects/amiga-subversion-port/

I have imported MiniGL repo into a private Github repo instead, for browsing purposes. I suppose it can be cloned natively with sgit if required.

@Capehill

Thanks for the reminder about svn. Yesterday, I checked locally, I'm pretty sure I installed this new version some time ago ... but it seems that was not on the X1000 ...

About sgit, it should be capable, as I cloned ScummVM with it successfully.

@corto

With sgit i'm also getting to the 75% ram barrier.
After the merge the changes were huge and sgit was filling up ram to 72%.

As long as there is no fix to that dreaded bug released i might be forced to stop compiling one way or another.

@corto

I get a crash with that minigl fix on starting Grim in OpenGL mode (Software works, but is broken in gfx display and colors).

So i guess that "fix" introduced new problems ... sigh

@Raziel

Please post a stack trace..

@Capehill

Excuse the delays...

serial


grimreaper