Porting to AmigaOS4 thread

@LiveForIt

I'm not proposing to do both. Either manual OpenLibrary + GetInterface or -lauto.

@Capehill

Is there example code somewhere?
For an amigaos4 suitable solution...as easy as it can get, please

@Raziel

Here is one example regarding manual opening of the asl.library: https://github.com/capehill/MilkyTrack ... iga/AslRequester.cpp#L110

Jabirulo made one too.

I was fetching the latest ScummVM sources yesterday so I can try to assist, but I need your changes + new files.

@Capehill

On it, thank you, i'll shout if/when i get stuck again

@Capehill

Could you help me to
1 - get rid of the warnings
2 - to use utf8
3 - polish (or rather fix) the code
please

especially utf8 is way beyond me

Thank you

These are the warnings and the utf8 error


and here is amigaos-dialogs.cpp

@Raziel

Not sure but try this, and hope it removes some ASL warnings.




In case it warns about:
extern struct Library *AslBase;
extern struct AslIFace *IAsl;
just comment them out.

@jabirulo

I need to add i have no idea how to incorporate the utf8 stuff

@Raziel

Maybe you need to put those definitions:
extern struct Library *AslBase;
extern struct AslIFace *IAsl;
on top of amigaos-dialogs.cpp, before includes.


BTW I forget to "NULLify" ASL variables at end:
Exec->DropInterface((struct Interface*)IAsl);
IAsl = NULL;
IExec->CloseLibrary(AslBase);
AslBase = NULL;

@jabirulo

Nope, still undefined refs on linking...the two extern structs are still inisde the if defined __amigaos4__

@Raziel

Try tu put amigaos-dialogs.o as first file of linking objects.

@jabirulo

That won't be as easy, the objects to link are hardcoded within the scummvm configuration.

If i i change it once i'll have to change it everytime new code arrives...

How is amigaos-dialogs.cpp added in the makefile (or whatever file makes the build)?

Can you see on your Shell/CLI/terminal the whole linking line/commandline?

Maybe just copy&paste such linking line in a self made script and the you execute such script manually.

@Raziel

Don't use "extern". Also move Asl symbols outside the function to avoid "shadowing" warnings. In proto/asl.h symbols are declared as globals that's why compiler was worried.



utf8ToLocal: as said you need to implement this function in the cpp. Check the corresponding MorphOS implementation.

@Capehill
@jabirulo

Boy, this compiler is picky

I managed to move around stuff so i get it to build without warnings, thanks a lot for the help

Now i'd like to implement the utf8 stuff (noob here aswell) but MorpHOS seems to use some stuff that is not available, or maybe i hvaenßt found it in the SDK (yet)?

This is the codesets part i have in now

But i get compiler errors and warnings...do i miss an include, maybe?

Especially FSGetByteSize and ConvertTagList seem to be nowhere in my SDK.

And what does that "expression cannot be used as function" mean?



Thanks for all the help guys, really appreciated...not that i'll learn much from it, but, yeah

@Raziel

You need to add IFace:
struct CodesetsIFace *ICodesets = NULL;
...
ICodesets = GetInterface((struct Library *)(Codesetbase), "main", 1L, NULL);


and close at exit/end:
DropInterface( (struct Interface *)ICodesets );
ICodesets = NULL;
...

Are those missing functions part of MorphOS/OtherOS?
Or part of your port/sources?
If part of MorphOS, check MorphOS sdk autodocs and see such functions and then try to amigaos4'ize thrm.

EDIT: seems theyu a part of MorphOS charset autodoc:
charsets.library/ConvertTagList()
charsets.library/GetByteSize()

Yo can try to adapt parts in convert.c example (codesets archive) and replace in your port/sources.

@jabirulo

Thank you, funny it didn't warn me about those.

Will try to find some info for FSGetByteSize and ConvertTags, thanks for the hints

@Raziel

I think the missing ICodesets will shown only on linking stage.


codesets has somethiong like "ConvertTagList":

char *destbuf = CodesetsConvertStr(
CSA_SourceCodeset, srcCodeset,
CSA_DestCodeset, destCodeset,
CSA_Source, buf,
CSA_DestLenPtr, &destlen,
TAG_DONE);

You just need to "fill the gaps/variables" (convert.c example)

@jabirulo

That's what i thought too, but there were no linking errors.
Anyway, i've placed these lines now, shouldn't hurt.

"Filling in the gaps"...yes, but if you don't know the language you might get in trouble, just like with a gap text exam

@Raziel
ok, ok.
I already used such function/method, will post it here ASAP and hope it will work for you.

@jabirulo

Thank you, but it was not meant to throw the ball back to you.

I was going fo look up those functions, just not right now