Login
Username:

Password:

Remember me



Lost Password?

Register now!

Sections

Who's Online
134 user(s) are online (122 user(s) are browsing Forums)

Members: 1
Guests: 133

VooDoo, more...

Support us!
Donate

Headlines
Recent files - OS4Depot - Your one stop for AmigaOS4 files

 
Jump to the bottom of the page Bottom    View previous topic Previous Topic    View next topic Next Topic

  Register To Post  

kas1e
signed char became unsigned ?
Posted on: 2021/1/21 19:42    #1
Home away from home
Home away from home


See User information
@All

Have some theoretical question.

I do work on some port of a game, which is C++ and which have such a class:

class Door : public Object
{
    public :
        ...balbalba...

    private :

        ...balbalba...

        char _direction;

        ...balbalba...

};



Now, in the code of the game, depending on the needs, we have set _direction to be 1 or -1. Like this:

void Door::setDirection(core::vector3df ref)
{
    if (_doorType == DT_ROTATE_X)
    {
        if (ref.Z < _rotateCenter->getPosition().Z) _direction = 1;
        else _direction = -1;
    }
    else if (_doorType == DT_ROTATE_Z)
    {
        if (ref.X < _rotateCenter->getPosition().X) _direction = -1;
        else _direction = 1;
    }
}


And when I build it for win32 and when puts prints with %d in relevant parts, it prints 1 or -1 when should.

But when I do the same on amigaos4, it prints then 1 and 255 instead of 1 and -1 (i.e. -1 became 255).

I.e. exactly the same code line per line. Just 2 binaries, one for aos4 and one for win32.

I feel it's something trivial, just can't get what. Does it look like signed char become unsigned? Maybe I need specially specify that this is signed? Or maybe some flag to GCC need to be passed, or it just bad code-practice somewhere?

Maybe in win32 pure "char" mean "signed char", but on amigaos4 pure "char" mean "unsigned char" ?:)
Join us to improve dopus5!
AmigaOS4 on youtube
Go to top
kas1e
Re: signed char became unsigned ?
Posted on: 2021/1/21 20:00    #2
Home away from home
Home away from home


See User information
Damn right, win32:

$ cat test.cpp
#include <stdio.h>
int main()
{
        char _direction;
        _direction = -1;
        printf("_direction = %d\n",_direction);
}

$ gcc test.cpp -o test
$ ./test
_direction = -1



Amigaos4:

2/10.Work:test> cat test.cpp
#include <stdio.h>
int main()
{
        char _direction;
        _direction = -1;
        printf("_direction = %d\n",_direction);
}

2/10.Work:test> gcc test.cpp -o test
2/10.Work:test> ./test
2/10.Work:test> _direction = 255


So seems just different defaults. Strange through why differences have a place at all between platforms in such case.
Join us to improve dopus5!
AmigaOS4 on youtube
Go to top
salass00
Re: signed char became unsigned ?
Posted on: 2021/1/21 20:20    #3
Just can't stay away
Just can't stay away


See User information
@kas1e

Whether char type defaults to signed or unsigned is and always has been platform dependent. If you require a specific type of char (signed or unsigned) you should specify it in the variable definition.

In this case:
signed char _direction = -1;
Go to top
Thematic
Re: signed char became unsigned ?
Posted on: 2021/1/21 20:44    #4
Quite a regular
Quite a regular


See User information
There should be a warning in gcc for that. It's *the* cross platform toolchain.
Go to top
flash
Re: signed char became unsigned ?
Posted on: 2021/1/21 21:13    #5
Just popping in
Just popping in


See User information
These is a gcc compiler option about how to manage chars datatypes.
Maybe on windows defaults are different from others platforms.
As suggested you can declare var as signed char and look at debug printf output just to verify.
Memento audere semper!
Go to top
kas1e
Re: signed char became unsigned ?
Posted on: 2021/1/21 22:03    #6
Home away from home
Home away from home


See User information
@All
As code is written like this, probably it's better to use --fsigned-char GCC option then? Or it may fix this part, but fail then in another...
Join us to improve dopus5!
AmigaOS4 on youtube
Go to top
billyfish
Re: signed char became unsigned ?
Posted on: 2021/1/21 22:18    #7
Just popping in
Just popping in


See User information
@kas1e

-fsigned-char should do it for you in GCC.
Go to top

  Register To Post

 
Jump to the top of the page Top    View previous topic Previous Topic    View next topic Next Topic




Currently Active Users Viewing This Thread: 1 ( 0 members and 1 Anonymous Users )




Powered by XOOPS 2.0 © 2001-2024 The XOOPS Project