Odyssey 1.23 progress: r5 RC2

@kas1e

I am not sure how Odyssey handles CERTs that are self signed, so cannot be validated at any Cert Authority..

Even if less secury based on the self signed Cert.. its still encrypted HTTPS traffic based on that Cert.

Good question.....

@Skateman
In netsurf it is also handled as in ibrowse. Through without nice window and just render information in the browsers window with CSS button "procced" but also can handle it.

What we need now is to find where in Odyssey's to handle return error, so if we will have "SSL peer certificate or SSH remote key was not OK" error, then add code to bring nice mui window with buttons "continue unsafe" / "abort".


This error "SSL peer bablalba" is coming from LibCurl. So at least all the connections happen to be with Curl, and all we need is to search on world "curl" in all the Odyssey's sources to find out where those errors checks happen.

@kas1e

Looks like similair issues: https://stackoverflow.com/questions/27 ... certificates-in-wkwebview

But i cant help with coding stuff .... sorry ..

@Skateman




So I can just add this functionality to just "ignore SSL errors" by default. Or create a new option in the security tab with "allow self-signed certs" (which IMHO better). Later for the next releases, we can make a proper mui window with process/about maybe, etc. But not sure maybe just an option in prefs/security will be enough?

@kas1e

I would opt for the Allow Self Signed Certs as an option in the security tab.

Great work !!

@Skateman




Only left to add proper CD/locale stuff (for now that just English only string)

@kas1e
Quote:
Thanks for the new update. Testing now. So far it's working well.

Quote:
I've found that if I spoof as ipad 13.2.3 it works but if you scroll to the bottom of the page automatic loading of more videos does not work. If I spoof as ipad 6.1 then the automatic loading of new videos when I scroll to the bottom of the page works as it should.

I'd recommend spoofing as ipad 6.1 in step 2 above.
Does anyone see different behaviour?

@Breed

Worked for me here just fine...

@kas1e

Excellent.. hope this could help with my isp too

If later you need to add/adjust strings in CD, well there are almost other 6 missed:


1) "Trasferred a partial file" --> in download window

2) "Download failed" --> in download window

3) "Save As..." --> in asl requester title when saving something

4) "link URL" --> in mime type prefs

5) "generated local path" --> in mime type prefs

6) "ODYSSEY REXX port" --> in mime type prefs

@kas1e

Looking good!! (some form of a security waring would be in place just like most browsers will give when visiting self signed cert websites)

A text/string close to the checkmark would do fine.

@Skateman

Not very understand what you mean :)

Do you mean need and option as it is now and a window with warning? Or do you mean only a window with a warning without this option?

Because if go with the window route, we have no needs to have this option in prefs as well (as we can in the window made 2 buttons yes/now).

@All
I think for the time being i go just the option route without localization (so to avoid mess for now) and for next betas, we can discuss how to handle it all better, and then localization can be added, etc. As i want to make os4depot release of what we have already.

@All

Odyssey 1.23 r5 RC2 - AmigaOS4

http://kas1e.mikendezign.com/aos4/ody ... as/odyssey_1.23r5_RC2.lha


-- Updated some catalogs.
-- Added script from Walkero to fix GitHub a little so it didn't look _that_ broken on our old WebKit core.
-- Added option in prefs/secure to allow unauthorized self-signed certs (while not secure it is still HTTPS).

The only thing i can worry about now for the os4depot release is if there is some bug in the self-signed option arising. if all ok in that terms => then os4depot.

@kas1e

What i mean is something like a simple txt line.

Self Signed Prefs

@Skateman
Aha got it. I think we will revisit the whole thing (with proper window etc) for later betas, just now we need to make an os4depot release and to have something which already works.

@kas1e

I Agree... submit to OS4Depot and let the world enjoy! RC2

@Skateman
Yeah need to wait for Samo/Raziel to confirm that the new option work for them and then :) For you all fine with your NAS ?

@kas1e

Its perfect! Tested on 3 synology boxes... All fine!

@kas1e

Will try in a minute

What was the problem?

@Raziel
ignore SSL errors were ignore all errors but not self-signed certs for that one some additional settings for curl should be set (which I do + add option to enable/disable that).

in other words, it just didn't handle before self-signed certs at all and drop the connection as "error".