flawfinder for AmigaOS 4

Just compiled




That's why I told you that you are mixing the libraries.
However it is using fork/waitpid to execute tests. How did you replace the functions?

@afxgroup

For whatever reason it's definitely using the wrong libstdc++.a (newlib version) for walkero. The clib2 version should be in a clib2 sub-directory from where the newlib one is.

@trixie

Quote:

There is the strnlen() function which is like strlen() but allows to limit how far the function will go to look for a '\0' character.

@afxgroup and @salass00
Yeah, I was compiling with the wrong libstdc++. You are both right.
I just compiled it with the right one and the linker worked fine, but not the binary. I had some crashes and I am going to test it further.

@LiveForIt

Quote:
True, it would be silly to use strlen() and then memcpy() when strcpy() would do the same thing more efficiently. But Flawfinder still considers strlen() a potential security flaw, so I was trying to give a simple example to demonstrate why. A little too simple, perhaps.

Quote:
Unfortunately, the standard C library does not have a good length-limited string copy. strncpy() sounds like it is, but if the source string is longer than the specified length then the destination string is not NUL-terminated. That keeps the destination buffer from overflowing, but results in an unterminated string, which rightly earns strncpy() a warning from Flawfinder.

Depending on how portable you want your code to be, there are non-standard alternatives such as strnlen() and strlcpy(). Both newlib and clib2 have these, but other C libraries may not.

@walkero

python seems broken here...

Quote:

Help

@Raziel
As much as I know this should come with the the OS and the updates. I would recommend you have a look at the AmigaOS 4.1 FE CD and the updates. If you can't find it, please let me know.

Today I released the cppcheck tool for everyone to use and test your code with.

You can find info at https://ko-fi.com/post/cppcheck-for-AmigaOS-4-released-F1F5F7C7T

You can download it from my personal Git repo at https://git.walkero.gr/walkero/cppcheck/releases and soon from OS4Depot.

Hope it will be useful for you.