AmigaOS port of libsmb2

@salass00

Thank You.
This version fixes my two issues .

@salass00

New issue :

Something seems to go to sleep after no file activity for a long time making the share unreachable .

I did some testing, and I might have found an issue. I can't delete folders if they are not empty. The operation appears to succeed and the drawer disappears on the Amiga side, but if I refresh I can see that it's still there. Removing empty folders works.

@BSzili

I can confirm that behavior when using a file manger like DOpus to do the delete.

However the delete works ok for me when using Workbench to do the delete even if the directory is not empty .

@BSzili

Not sure what you mean. That is how deleting normally works in AmigaDOS (and Linux too) if you call Delete() on a non-empty directory it fails with ERROR_DIRECTORY_NOT_EMPTY/ENOTEMPTY. In order to delete a directory with contents you have to recursively delete the contents first and only then delete the directory (if you use the WB delete function it does this behind the scenes, if you use delete command you have to use the ALL switch).

I just tried using WB to delete a couple of directories over smb2-handler on my AmigaOS 4.1 FE update 2 system and it worked just fine (I also checked on the Ubuntu host and the directories really were deleted).

That being said if whatever method you are using to delete using relies on IoErr() returning specifically ERROR_DIRECTORY_NOT_EMPTY after Delete(dirname) then that won't work with the current smb2-handler.

Sorry, I should have been more specific. I was using DOpus4, which can delete the contents first, but for some reason it doesn't. When I try to delete a non-empty directory it disappears until I refresh, as if the operation succeeded. I'll check the sources, it probably relies on the ERROR_DIRECTORY_NOT_EMPTY error code.

edit: You were right on the money, it apparently does:
https://github.com/aros-development-te ... pus/Program/main22.c#L609
https://github.com/aros-development-te ... opus/Program/main5.c#L301

@BSzili

There is something wrong in smb2-handler as well in that smb2_rmdir() returns success (zero) even though it did nothing.

I just tried the latest commits, and deleting with DOpus4 now works perfectly. Thanks!

@BSzili

You're welcome.

@salass00

Thank you for this work! I'm blown away by the performance of this code, I seen over 50 MB/s moving large files, never seen that on my X5000 before...

I have hit a snag. I went to back up my system using the Onyxsoft.se "backup" tool and I'm not able to even select the device from the file requester.

I'm mounting from my Linux machine and can move data both directions using the copy command from the CLI with no issues. Here is what "c:info" shows:

MEDIA: 2,046G 3,896G 2,245G 62% -1 Read/Write 10.0.0.20-Media SMB\02
TEKMAGE: 2,046G 3,896G 2,245G 62% -1 Read/Write 10.0.0.20-space SMB\02


However, when I use backup's file requester it reports the devices a 100% full, and more interesting, when I use something like multiview and list all the devices I see the drives as "190% full."

(MEDIA) 190% full, 2,245GB free, 3,896.9GB in use

When I mount the same partition using smbfs I see a different space accounting:

c:info
nas2: 2,047G 0K 2,047G 0% 1 Read/Write space DOS\00

ASL:
(nas2) 0% full, 2,047GB free, 512B in use


Thoughts?

Cheers,
Bill "tekmage" Borsari

@tekmage

Can you run smb2-statvfs-sync against your samba shares and report what it outputs?

You can get the program here:
https://www.dropbox.com/s/1tcz1xnoypj7ulg/smb2-statvfs-sync.7z?dl=0

Thanks for the tool!

17.RAM Disk:> smb2-statvfs-sync smb://tekmage:*************@10.0.0.20/space
Blocksize:1024
Blocks:10735329280
Free:2315610508
Avail:2315610508
17.RAM Disk:> smb2-statvfs-sync smb://tekmage:************@10.0.0.20/Media
Blocksize:1024
Blocks:10735329280
Free:2315590144
Avail:2315590144

@tekmage

The total blocks count is too large for id_NumBlocks. Try this version and report if it works better:

https://www.dropbox.com/s/t6nzkjocs7u870h/smb2fs-20230104.7z?dl=0

The reported fs block size will be larger than it actually is with this version, but the used/free percentages should at least be reasonably correct.

@all

Does libsmb2 work with Windows 10/Windows 11 shares ?

@SinanSam460

yes, but you might have to install samba 1.0/CIFS or/and samba
direct feature from the control-panel/programs/turn windows
feature on or off, you might have to use password/user since
windows 10/11 does not allow guest access to shares under certain
circumstances

@trgswe

Quote:

Definitely no need to do this for smb2-handler (only the ancient smbfs needs it). Libsmb2 has zero support for the old and insecure SMBv1/CIFS protocol (only SMBv2/v3 are supported).

That being said the current AmigaOS port of libsmb2 is limited to NTLMSSP authentication only (not sure if this is a problem) as it is built without libkrb5.

@salass00

Fixed the standard ASL:

TEKMAGE: 9T 8,067G 2,170G 79% -1 Read/Write 10.0.0.20-space SMB\02

Backup still has an issue. I suspect the problem is now with Backup and its ability to deal with the 10T volume.

I'll reach out to OnyxSoft and see what they say :)

Thanks!
Bill "tekmage" Borsari

@salass00

There seem's to be a bug in smb2 handling host-names... meaning
it doesn't, if i use my laptop hostname it won't mount it... but
if i use the ip4 address its onkyo dory, not to mention the
activate flag also seem's broken (will have to check more on
that) i have the active=1 in the tooltypes but when booting the
samba share isn't mounted and can't be mounted either

@trgswe

If your DNS is set to your ISP`s DNS or other exernal DNS (8.8.8.8) for example it makes sense it cannot find you laptops hostname.

If your DNS is set to your a local DNS server make sure a DNS record for your device is available.

It's always a good idea to ping the host name first to make sure it's reachable from that machine.