RadeonHD V.5 driver

	Bottom Previous Topic Next Topic
Register To Post

« 1 ... 12 13 14 (15) 16 17 »

geennaam

Re: RadeonHD V.5 driver

Posted on: 2023/2/9 18:43 #281

Quite a regular

@joerg

I am not sure what you are trying to say here but my driver uses DMA all over the place. And manual cache flushing/invalidating is required for the SAM460. It doesn't work without it.

The Sam460 Sata driver for the internal Sata interface is PIO only. UDMA is not implemented. The PCI Sata drivers have to do manual cache flushing of DMA buffers as well if they are in main memory. Or mark DMA buffers as non-cachable.

joerg

Re: RadeonHD V.5 driver

Posted on: 2023/2/9 18:48 #282

Just can't stay away

@geennaam
Don't remember if the on-board SAM440ep SATA controller works with DMA, but using a SII3112/4 PCI card instead does work with DMA.

geennaam

Re: RadeonHD V.5 driver

Posted on: 2023/2/9 19:00 #283

Quite a regular

@joerg

OK, final posting on this subject.

Nobody is claiming that DMA doesn't work on a SAM4x0. On the contrary. It does work.

As long as the driver flushes the cache after a cpu write to a DMA buffer and invalidates the cache before reading from a DMA buffer. On a cache coherent system like the X5000, you don't have to worry about this. The bussnooping mechanism makes sure that caches are up to date.

m3x

Re: RadeonHD V.5 driver

Posted on: 2023/2/9 19:03 #284

Just popping in

@geennaam

FROM the 460ex UM:

Quote:

The DDR controller utilizes 34-bits of the 36-bit PLB address.
The most significant 2 bits of the 36-bit PLB address (bits 28 and 29 of the upper 32 bit address) allow the 34-bit address to have an alias on the low latency and high bandwidth PLB slave segments.
Accesses with the upper two bits set to 0b00 are made over the low latency (LL) slave interface and accesses with the upper two bits set to 0b10 are made over the high bandwidth (HB) slave interface.

The internal SATA controller under AOS4.1 works in PIO mode because we didn't find any developer willing to write a DMA driver for it (it requires gather/scatter lists) Under Linux it works in DMA mode.

Max Tretene, ACube Systems Srl, Soft3

joerg

Re: RadeonHD V.5 driver

Posted on: 2023/2/9 19:06 #285

Just can't stay away

@geennaam
Maybe there is a difference between 440 and 460, but on the SAM440ep the PCI SATA drivers (SII3112, SII3114 and SII3152) do work with DMA, without manual cache flushes/invalidates in the drives.

joerg

Re: RadeonHD V.5 driver

Posted on: 2023/2/9 19:09 #286

Just can't stay away

@m3x
Quote:

The internal SATA controller under AOS4.1 works in PIO mode because we didn't find any developer willing to write a DMA driver for it (it requires gather/scatter lists) Under Linux it works in DMA mode.

Sorry about that, I got a board from you and tried to implement it, but couldn't even get PIO working.

The gather/scatter lists weren't a problem at all, I helped Ignatios to get that working with the CyberStormPPC AmigaOS 4.x SCSI driver.

Spectre660

Re: RadeonHD V.5 driver

Posted on: 2023/2/9 19:27 #287

Quite a regular

@m3x

there were some lock ups with the DMA under linux with newer Kernels if I recall correctly .

https://lore.kernel.org/lkml/146126254 ... evchenko@linux.intel.com/

Also GART seem to be enabled but ring test for hardware acceleration failed .

[ 3.121797] [drm] radeon: dpm initialized
[ 3.128222] [drm] Found VCE firmware/feedback version 50.0.1 / 17!
[ 3.134469] [drm] GART: num cpu pages 524288, num gpu pages 524288
[ 3.151139] [drm] probing gen 2 caps for device aaa1:bed1 = 18cc41/0
[ 3.210767] [drm] PCIE GART of 2048M enabled (table at 0x00000000002E8000).
[ 3.218077] radeon 0000:81:00.0: WB enabled
[ 3.222320] radeon 0000:81:00.0: fence driver on ring 0 use gpu addr 0x0000000040000c00 and cpu addr 0xee962c00
[ 3.232441] radeon 0000:81:00.0: fence driver on ring 1 use gpu addr 0x0000000040000c04 and cpu addr 0xee962c04
[ 3.242562] radeon 0000:81:00.0: fence driver on ring 2 use gpu addr 0x0000000040000c08 and cpu addr 0xee962c08
[ 3.252683] radeon 0000:81:00.0: fence driver on ring 3 use gpu addr 0x0000000040000c0c and cpu addr 0xee962c0c
[ 3.262805] radeon 0000:81:00.0: fence driver on ring 4 use gpu addr 0x0000000040000c10 and cpu addr 0xee962c10
[ 3.304324] radeon 0000:81:00.0: fence driver on ring 5 use gpu addr 0x0000000000075a18 and cpu addr 0xf5135a18
[ 3.341458] radeon 0000:81:00.0: fence driver on ring 6 use gpu addr 0x0000000040000c18 and cpu addr 0xee962c18
[ 3.351618] radeon 0000:81:00.0: fence driver on ring 7 use gpu addr 0x0000000040000c1c and cpu addr 0xee962c1c
[ 3.361759] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
[ 3.368404] [drm] Driver supports precise vblank timestamp query.
[ 3.374523] radeon 0000:81:00.0: radeon: MSI limited to 32-bit
[ 3.380446] genirq: Setting trigger mode 3 for irq 45 failed (uic_set_irq_type+0x0/0x160)
[ 3.388716] radeon 0000:81:00.0: radeon: using MSI.
[ 3.393673] [drm] radeon: irq initialized.
[ 4.152902] [drm:r600_ring_test] *ERROR* radeon: ring 0 test failed (scratch(0x850C)=0xCAFEDEAD)
[ 4.161744] radeon 0000:81:00.0: disabling GPU acceleration

Hans

Re: RadeonHD V.5 driver

Posted on: 2023/2/10 6:37 #288

Home away from home

@Spectre660

Quote:

@m3x

there were some lock ups with the DMA under linux with newer Kernels if I recall correctly .

https://lore.kernel.org/lkml/146126254 ... evchenko@linux.intel.com/

Also GART seem to be enabled but ring test for hardware acceleration failed .

Depending on which GPU series, that may be due to lack of endinness conversion. IIRC, the SI series is the last one where the command processor can be programmed to handle big-endian. AMD had already started removing bi-endianness at that stage, and some things already needed to be manually byte-swapped.

@geennaaam
Quote:

As long as the driver flushes the cache after a cpu write to a DMA buffer and invalidates the cache before reading from a DMA buffer. On a cache coherent system like the X5000, you don't have to worry about this. The bussnooping mechanism makes sure that caches are up to date.

That's the correct procedure. Amiga computers only recently started getting cache coherency.

I don't understand why manual cache flushing isn't working for GART. I flush/invalidate the cache everywhere where I think it's necessary followed by a sync instruction. Yet, it'll still locking up. The sync instruction should wait until the flush/invalidate is done. Maybe there are other problems (e.g., a cache in the PCIe controller). Or maybe I'm doing something incorrectly in the driver.

Hans

Join Kea Campus' Amiga Corner and support Amiga content creation
https://keasigmadelta.com/ - see more of my work

Spectre660

Re: RadeonHD V.5 driver

Posted on: 2023/2/10 11:51 #289

Quite a regular

@Hans

Nobody has managed to get DRM working properly on Sam460 machines with anything from Radeon RV515 cards onwards.

Edited by Spectre660 on 2023/2/10 12:14:23

joerg

Re: RadeonHD V.5 driver

Posted on: 2023/2/10 14:02 #290

Just can't stay away

@Hans
Quote:

The sync instruction should wait until the flush/invalidate is done.

IIRC there are different sync instructions on the different Power(PC) CPUs and not all of them may wait for cache flush/invalidate to complete, or aren't even implemented at all (no-op) on some CPUs, but the HAL parts used by the IExec->Cache*() and IExec->*DMA() functions should work correctly on all CPUs incl. the required sync.

Are you using the exec functions, or dcbf/dcbi and msync+isync manually?

Hans

Re: RadeonHD V.5 driver

Posted on: 2023/2/11 0:59 #291

Home away from home

@joerg

Quote:

Are you using the exec functions, or dcbf/dcbi and msync+isync manually?

I'm using the IExec->Cache*() and IExec->*DMA() functions.

It's also possible that the PCIe controller may have a cache that goes stale. PCIe appears to have some form of snooping capability (there's a "no-snoop" configuration bit).

This reminds me a bit of a problem I had with putting the command buffers in VRAM. There was a chance that the data wouldn't arrive in VRAM in time before the GPU started reading it. AMD's engineers said that was why they don't put the command buffers in VRAM; there's no mechanism to delay the GPU read until the data is in. I managed to get it working by waiting for the GPU to be idle before committing the next buffer.

Hans

Join Kea Campus' Amiga Corner and support Amiga content creation
https://keasigmadelta.com/ - see more of my work

PixelHi

Re: RadeonHD V.5 driver

Posted on: 2023/2/13 2:46 #292

Just popping in

Is there any hope to fix issues with v. 5 Radeon HD and 3d functionality on Sam460 with r7 240/7750? Or I need to do something to make it work?

It seems that RadeonRX driver works fine with Rx 550, and 3d related software work fine.

Hans

Re: RadeonHD V.5 driver

Posted on: 2023/2/13 7:12 #293

Home away from home

@PixelHi
Quote:

Is there any hope to fix issues with v. 5 Radeon HD and 3d functionality on Sam460 with r7 240/7750? Or I need to do something to make it work?

The fixes I mentioned days ago should make it all work.

Hans

Join Kea Campus' Amiga Corner and support Amiga content creation
https://keasigmadelta.com/ - see more of my work

Hypex

Re: RadeonHD V.5 driver

Posted on: 2023/2/17 11:43 #294

Not too shy to talk

@Hans

Quote:

The ring buffer is likely the first place where you'd hit problems with lack of cache coherency. However, if you're using an SI card or newer, then the problem could also be that their drivers can't handle big-endian.

In this case it was a 9200SE so certainly old enough to support big endian.

Quote:

IIRC, ACube did have a Linux driver that worked with GART enabled. I don't know for which cards, or how it worked.

That's interesting. Rarely are Linux drivers superior to OS4 drivers. In this kind of way.

Quote:

I can think of one way to get GART working, and that's to mark all memory used for GART as non-cacheable (or disable the data cache entirely). The L2 cache might need to be disabled too. Needless to say, doing so would come with a serious performance penalty.

I can imagine so. It would be impractical to keep it off. But also if it was disabled for each transfer.

joerg

Re: RadeonHD V.5 driver

Posted on: 2023/2/17 18:25 #295

Just can't stay away

@Hans
Maybe instead of disabling the caches completely using write-through instead of copy-back mode for the caches could help?

I don't know if that's possible at all with the IMMU functions, nor if the 440/460 CPUs support it. I did that change in beta versions of the A1200/A4000 603/604 CPU kernel for my classic Amiga beta testers. Not because of DMA, there isn't any DMA on classic Amigas in AmigaOS 4.x anyway, except for the CyberStormPPC SCSI driver, but because it was faster.

Hans

Re: RadeonHD V.5 driver

Posted on: 2023/2/18 0:15 #296

Home away from home

@joerg
Quote:

Maybe instead of disabling the caches completely using write-through instead of copy-back mode for the caches could help?

Unfortunately, no.

Hans

Join Kea Campus' Amiga Corner and support Amiga content creation
https://keasigmadelta.com/ - see more of my work

sailor

Re: RadeonHD V.5 driver

Posted on: 2023/4/20 19:43 #297

Not too shy to talk

Just now tested new Radeon HD v.5 for AmigaOne X1000 and is significantly faster than v.3:

Doom3 (HunoPPC), same config (XFX Radeon HD 7970 Black Edition, 1920x1080, All advanced options disabled, GLSL renderer, seta r_speedHackShadow "1.033"):
RadeonHD v5: 25.7 FPS
RadoonHD v3: 17.6 FPS

+46%

AmigaOS3: Amiga 1200
AmigaOS4: Micro A1-C, AmigaOne XE, Pegasos II, Sam440ep, Sam440ep-flex, AmigaOne X1000
MorphOS: Efika 5200b, Pegasos I, Pegasos II, Powerbook, Mac Mini, iMac, Powermac Quad

ktadd

Re: RadeonHD V.5 driver

Posted on: 2023/4/21 7:30 #298

Quite a regular

@sailor
Quote:

Just now tested new Radeon HD v.5 for AmigaOne X1000 and is significantly faster than v.3:

Could you do me a favor and try playing videos with MPlayer? When use v5 driver on my X1000 with a 7550 grapohics card, MPlayer will eventually freeze when it's playing a video. I haven't been able to get anyone else to try it and see if that happens for them as well. I've going back to the older version because of this problem. Please....

AmigaOne X1000, A1222Plus, uA1

sailor

Re: RadeonHD V.5 driver

Posted on: 2023/4/21 18:27 #299

Not too shy to talk

@ktadd
tried RadeonHD v.5 + MickJT, LiveforitHD and LiveforitNG MPlayers.
all works, no freezes.

Only this players have no UVD support yet, CPU is utilized upto 80-100% with HD (and some fullHD) videos (altivec versions).
With Emotion or DVPlayer CPU is 15-20%. Unfortunatelly both DVPlayer+Emotion though saves CPU, still not capable of higher resolution videos with X1000+RadeonHD.

Do you have specific video which not works for you? I can test it.

TSK

Re: RadeonHD V.5 driver

Posted on: 2023/4/21 23:28 #300

Just can't stay away

@ktadd

I have that problem on X1000+HD7700+v5.

Rock lobster bit me - so I'm here forever
X1000 + AmigaOS 4.1 FE
"Anyone can build a fast CPU. The trick is to build a fast system." - Seymour Cray

Register To Post	« 1 ... 12 13 14 (15) 16 17 »
	Top Previous Topic Next Topic

Currently Active Users Viewing This Thread: 2 ( 0 members and 2 Anonymous Users )