ProTracker clone

@trixie

Thanks for taking another look and maybe improving the quick port a bit. In the meantime I have tested PT2-Clone directly under MacOs, but the tracker crashes and I cannot confirm whether the window output is a problem with SDL2 under AmigaOs4.1 or is a problem with this tracker in general.

There is another tracker on https://16-bits.org/ft2.php, namely Fasttracker 2 Clone. This porting could also be very easy and so we would have 3 trackers to choose from, I would think that would be great. It doesn't have to be immediately, but maybe in the future.

hey,

Can you test with false value here:

https://github.com/8bitbubsy/pt2-clone ... r/src/pt2_visuals.c#L1983

I try on MorphOS and this flag corrupt mouse coords...

@beworld

I have set


combined with HWMOUSE=TRUE in the protracker.ini fine, and the mouse behaviour in the window mode seems to be fine now!

@Maijestro

I've also added a proper Amiga version string and a stack cookie. Please download my test build (including the configuration file), and if it works fine, feel free to replace the existing OS4depot file.

@trixieQuote:

First of all, thank you very much for the test build, I have already tested it briefly. The software SDL2 mode is unfortunately unusable on my machine and causes the system to simply hang without an error message or GrimReaper in the window output. However, full screen works very well.

About SDL2 OpenGL and Wazp3d your build works in the window output, but shows me wrong colors (problem with Wazp3d), additionally I have to change "HWMOUSE=TRUE" to "HWMOUSE=FALSE" otherwise no mouse pointer is displayed which is not the problem, because this can be switched on and off in the ini. (Hardware mouse pointer is not supported under Qemu Pegasos2, just like OpenGL 3D acceleration is not available). In the Wazp3D SDL2 OpenGL output, the mouse pointer behaves correctly and all functions are also hit when clicking. Exiting the SDL output window also seems to work.

Since I can't test your build to the full extent under AmigaOs4.1, (hardware mouse pointer, 32Bit windows, 3D acceleration, I can only describe that the window output of PT2-Clone at least in the software usage of SDL2 is broken under Qemu Pegasos2.

On real hardware there shouldn't be these problems, but I myself can then only use this tracker in full screen until things perhaps change. But it would be fine for me if you can confirm that it runs fine on your hardware.

Ok there is a solution for everyone and it is the Beworld patch, window output is displayed correctly including mouse interaction. SDL2 software/OpenGL 16/32 bit works without problems.

Smarkusg has merged the patch with PT2-Clone and recompiled it.

Configured for real Hardware:

VIDEOSCALE=AUTO -----> The window size adjusts automatically depending on which resolution is used under AmigaOs4.1.

HWMOUSE=TRUE ------> Using hardware mouse pointers

FULLSCREEN STRETCH=TRUE -----> Stretches to the full screen size (resolution) in full screen mode

@Beworld

Thanks for providing this patch

@smarkusg

Thank you very much for merging the patch and recompiling PT2-Clone.

I will update the archive on Os4depot again. Thanks to all for the help.

Yay! Great effort, guys.

@Maijestro, @Smarkusg

That's fantastic news!

It would be great if the Amiga-specific parts were pushed upstream in the official GitHub repo, to avoid applying them every time a new version is released.

@trixieQuote:

This is an excellent idea, but I don't know how to do it, so I would have to ask smarkusg again or someone does this who knows how to do it.

As far as I know, this tracker is still being worked on and there will certainly be new releases over time.

@all
Yes, last version works as expected, no more glitches with buttons in window mode, cool :)

@trixie

Quote:

I will certainly do this. I'll send as an issue or post as a patch.
@8bitbubsy did everything to make it work. Just enough to give a few things.

I'm very happy that the fun of the compilation resulted in a successful version.

@beworld @trixie

Thanks for the quick bugfix!

@smarkusg

Quote:
I'm afraid there'll be some more work Apparently there is a bug in module saving. I loaded three IFF samples and tried to make a short tune, but after saving and reloading the module I realized that the samples had been saved wrongly. The first sample slot had all the three samples joined together into one, and the other two sample slot contained garbage. I haven't tested the Windows version yet to see if the saving works there; if it does we might be facing an endianness problem.

@trixie

Yes you are right . I have also checked the Morphos version - there is also this problem. This will have to be corrected. Thanks for finding the bug.

https://ibb.co/HXLHgGj

@trixie

Thanks for doing this Trixie. Last time, 2022 maybe, when I used PT2 was on Linux, got snap package from the snap store. Everything was working as expected and I messed around a lot with PT2, since I was learning how to make mod music. I was able to save/load with no issues, however, this was version 1.25:

PT2 video example with version number

Not sure how helpful this is...

Oh, i think it's a byte swap (BE) problem... i try to find, thanks for report.

PS:
ok i think i found, sorry but i create only MorphOS build to test:
https://www.morphos-storage.net/upload/test/pt2-clone

if ok, i give you patch.

Quote:
Yesterday I re-created the current version of pt2clone under ubuntu/linux x86_64 - the problem did not occur there.

Quote:
also generated 3 modules yesterday. one caused the progam to fail - in the other two there were only faulty samples. The track itself was saved correctly.
Hopefully you haven't lost your work and will only be able to add samples to the track.

@beworld

Thank you very much once again for your help. Best regards and good luck with your new projects !


I will check in the evening when I am at home and let you know on PM

@beworld

Quote:
Thank you for fixing the issue and providing a patch!

Situations like this make it even more important that the Amiga/MorphOS fixes get incorporated into the official GitHub source file repository. Otherwise we'll have to go through this over and over again.

@smarkusg

Quote:
I'll continue testing the program. ProTracker represents a major part of the Amiga legacy, so I'd like to see it fully working under OS4 as well. If/When the official sources include the Amiga parts, I'd like to pitch in and add some Amiga-specific functionality such as system clipboard support. This way you could easily exchange samples between ProTracker and sample editors that support the clipboard, such as Rave and AmiSoundEd.

@trixie

Thank you for the bug report and for wanting to add functions to this tracker. As you have already written, Protracker has experienced a lot of history and the original was originally created on an Amiga. So we should make this tracker usable under AmigaOs4.1 as best as possible.

@Beworld

Thank you very much for the patch fixes you provide and even though you prefer MorphOs, your behavior should be exemplary for others where it's not just about pushing your own system.

@smarkusg

If you have put together the new version with the patch and need a tester and uploader, I am of course at your disposal.

@all

Great little project - even if it's just about porting a tracker, there is already a lot of support.

so... bad new... all save function are affected:

MOD2WAV
PAT2SMP
DISK OP. / SAVE MODULE -> seem ok after swapping some vars
DISK OP. / SAVE SAMPLE

https://github.com/8bitbubsy/pt2-clone ... rc/pt2_module_saver.c#L30

L30 - L48 - L49: add SDL_Swap16()

@beworld

aha ok ... so it's not as beautiful as it was supposed to be. Thanks!! I will check.
Of course if I find anything else I'll let you know.