While searching for the plugin that causes TuneNet to crash upon exit, I think I might have found another bug. If I have more then 25 plugins installed TuneNet puts up an Assign Requester with a bogus volume name when TuneNet starts up and when it exits. I can just simply cancel the requester and TuneNet works without any problems, but it is slightly annoying. Anybody else have more than 25 plugins installed and does it do the same?
Valiant@Camelot AmigaOne XE, 800Mhz, 1GB, 9250 Radeon, OS4.1u7 Sam440ep, 666Mhz, 512Mb, 9250 Radeon, OS4.1u6 A1-X1000, 1.8Ghz, 1GB, 9250 Radeon, OS4.1x A1-X5000/40 2.2Ghz, 2GB, Radeon HD 7700, OS4.1 FE ud 2
I didn't realise there were so many plugin's available. I'll check the code as I thought I'd put a limitation in there. Looks like that limit code isn't working and it's trashing the place.
The plugin pointers are held within a static array and not a linked list, and there should be a limit. I'll make sure that limit goes up (64 be enough?) and that the limiter check works.
Whoops. Only 24 plugins are allowed, and the check code is messed up. Sorry all! Anything over 24 players will start to corrupt memory, please remove some players for the time being.
I'll get a service release out as soon as possible.
Typing on a mobile device so this will be short! Skins : Have you installed the expat library? See TuneNet site downloads for details. If so try one of the example skins ( lights ) that definately works.
Aweb : Can you describe fully?
Plugins : I'll check the crashlog when I can get to an Amiga?
64 would probably be enough for time being, though 128 would probably be safer.
IMHO it would be better to use a linked list unless TuneNet does a lot of indexed lookups as this is slower. Exec linked lists are quite easy to handle using exec.library functions. There are also functions for doing name lookups (Find(I)Name) as well as sorting by priority (Enqueue). I use both of these features for the plugin interface in diskimage.device.
If it does use lots of indexed look ups then a solution would be to dynamically allocate the array and simply allocate a bigger array (about two times the old one's size would probably be good) if it finds more plugins and copy over everything from the old one before freeing it.
In either case there wouldn't be a hardcoded limit on the number of plugins.
The system now correctly truncates to the max number of players (64). I will make this dynamic on the future, the playlist, radio list and other things all use lists (actually a mini DB class I wrote). I was just a bit lazy in the plugin department! :) I will follow up your suggestion.
The crashog supplied suggests that a the save playlist is failing, specifically a file write. I'm wondering if a plugin is the cause of it (memory / file system errors). It's possible that a clean up on one of the plugins is not cleaning itself up properly.. Maybe, it cleans something up from TestPlayer() that is never used when you don't open a song??
Can you:
a/ check all plugins are up to date and reboot.
b/ Clear down to 0 plugins and launch / quit.
c/ Add a plugin, and keep doing step c until the problem occurs then note which 2 plugins were last added.
Without TuneNet, everything is fine as soon as TuneNet was started and fully closed again, AWeb will start crashing with "AWeb retrieve task". Further investigation of the crashlog reveals not much to me, maybe you see something interesting?
Problem is it's crashing permanently once it has started, one can "Ignore" but it will be 100% sure to pop up again on the next site access.
We had this crash before, there is a thread on Amigans.net already, unfortunately we thought it fixed back then... probably a plugin related issue too?
Skins : Have you installed the expat library? See TuneNet site downloads for details. If so try one of the example skins ( lights ) that definately works.
I had an old expat.lib installed (v4.3 from i don't know where) instead of OS4depot.net's 2.3 (It IS hard to keep up to date with those versions around)
Ash on my head, sorry for the hazzle on this one
Quote:
Can you:
a/ check all plugins are up to date and reboot.
b/ Clear down to 0 plugins and launch / quit.
c/ Add a plugin, and keep doing step c until the problem occurs then note which 2 plugins were last added.
a/ Everything up-to-date, not one old version around, i even found one (MSX) which i hadn't before
b/ Done - no crash AND no AWeb oddities (!)
c/ Done - no crash upto 32 plugins AND no AWeb oddities either. BUT with adding a 33rd plugin i get AWeb's bad behaviour again, still no crash though.
...testing on
OK, heres the resumee, i got ZERO crashes on quit, need to test further as this was no real life(tm) case, but it seems it could have been my old expat.lib(?)
I have done some testing and for me the AWeb crash you describe happens if and only if the System GUI is enabled (I usually have it disabled and use the SkinFX GUI only). I'm thinking it may be related to the internet radio stations but I'm not sure.
Yes, i am quite sure it has to do with the radio stations, maybe even only with the lists of the stations. It seem to grab the list online and there does something funny ... together with the System GUI it makes AWeb freak out.
News feed
OS4 Feedback forum
OS4Depot Feedback forum
Amigabounty forum
OpenAmiga forum
AmiCygnix forum
ABC shell forum
AmiKit forum
Cinnamon Writer forum
CodeBench forum
Digital Universe forum
Dopus 5 forum
E-UAE forum
Gnash forum
Ibrowse forum
JAmiga forum
Odyssey forum
OWB forum
Qt forum
SmartFileSystem forum
Timberwolf forum
TouchDevice forum
TuneNet forum
Unsatisfactory Software forum
Donate
