[Solved] Updating newmenu

Is there something like ResetMenuStrip() for newmenues ?

I need to enable/disable menu entries on the fly.

@orgin

Why not use OnMenu()/OffMenu()?

I use these functions in AmiSoundED.

@salass00

Leads to a hard crash. What exactly am I supposed to put in the "menunumber" field?

@orgin

FULLMENUNUM(menu,menuitem,subitem)

From memory...

@Chris

Hmmf I see, extremely annoying, means I have to scan the entire menu tree several times to find all the items I need.

Is there really no better way to do this? In comparison it seems easier to just iconify and deiconify the window. (the menus are remade when you do that)

@orgin



How does one invoke OM_UPDATE on a window?

@orgin

RethinkLayout()? Might be a bit overkill.

Why do you need to scan the entire menu tree?

Chris

@Chris

The newmenu array is just a flat array. I do not want to index it directly since I change it a lot. Which means that I scan the array items for the correct userdata field to find the items I want to enable/disable.

Using the mentioned define/macro means that I need to know which (sub)menu the item is in as well, which can change. Which basically means that I have to make my own tree structure out of the menu array so I can find which parent a certain item has.

WM_RETHINK had no effect.

RethinkLayout is intended for the gadget layout, not menu.

@orgin

You could obtain a pointer to the menu strip using:

Object *window_obj;
struct Menu *menu;
GetAttr(WINDOW_MenuStrip, window_obj, (uint32 *)&menu);

and then ClearMenuStrip(), make your menu changes and ResetMenuStrip().

@salass00

Tried that, had no effect. I don't think that is related to newmenu but the old style menu.

@orgin

MenuStrip is the old-style, but the GadTools functions convert from NewMenu to MenuStrip - Intuition only deals with MenuStrip.

So if you grab the MenuStrip, update your NewMenu, you would then have to run it through the GadTools function (CreateMenu()?) to get the new MenuStrip, and re-apply it.

Or you could just SetAttrs(WINDOW_NewMenu) and dispose the old one, ignoring MenuStrip entirely.

@Chris

Thanks, this solved it:

@orgin

You are modifying the menu strip and not new menu, right?

If it's the latter you need to use SetAttrs() with WINDOW_NewMenu tag:

Object *window_obj;
struct NewMenu *newmenu;
SetAttrs(window_obj, WINDOW_NewMenu, NULL, TAG_END);
/* make changes to newmenu structures */
SetAttrs(window_obj, WINDOW_NewMenu, newmenu, TAG_END);

@orgin

Quote:
I'm using this:

struct NewMenu MainMenu[]=
{
{ NM_TITLE,"Project",0,0,0,0 },
{ NM_ITEM,"About...","?",0,0,0 },
{ NM_ITEM,"Iconify","I",0,0,0 },
{ NM_ITEM,"Quit","Q",0,0,0 },
{ NM_END,NULL,0,0,0,0 }
};

enum
{
PROJECT_MENU
};

enum
{
MENU_ABOUT,
MENU_ICONIFY,
MENU_QUIT
};

IIntuition->OffMenu(MyWindow,FULLMENUNUM(PROJECT_MENU,MENU_ICONIFY,NOSUB)); // Iconify
IIntuition->OnMenu(MyWindow,FULLMENUNUM(PROJECT_MENU,MENU_ICONIFY,NOSUB)); // Iconify

No need to refresh or reset anything at all.

@TSK

I have several menus and I do not want to hard code which one an entry is in. So to find what menu an item is in means keeping track of the menus. Which is overkill just to refresh the menu. (I tried to explain all of this above but I guess it wasn't clear enough)

But anyway, the issue is solved so unless it's not legal to do what I said earlier there's no need to find any other solution.

@orgin

Quote:
Quote:
You said OnMenu and OffMenu were crashing so I showed an example only. (Looks like Chris answered already to you.)

Quote:
So, do you mean you're adding and removing menu items on the fly instead of just disabling and enabling them ???

@TSK

"So, do you mean you're adding and removing menu items on the fly instead of just disabling and enabling them ???"

Nope.