SDL developers.. please read

@Developers

Until i prepare a new SDL package, please download and compile the SDL from http://code.google.com/p/os4sdl/ since it fix some problems on keyboard handling and also on dynamic GL loading.
If you suspect some bugs please file always a bug on the site so we can try to fix it.

@afxgroup

So, if you in interest to works on it right now, i have a one bug-report, which i not fill on google page, and not create a new topic, just because i can't myself clear understand why it happenes, and what cause it.

The bug happenes for me (as i already test) in 2 games. Latest svn's Heroes2 (not release it because of that bug), and , Hexen 2 on which HunoPPC works for now (and also wait for that fix), but i already test beta version (so, if you in interest i can provide a link for).

Bug happenes when user swith beetwen window and full-screen modes, but not from menu (and i think not by SetVideoMode fucntion), but for in Heros2 when user press F4 (and i found that there is WM_Toggle fucntion are used), and Alt+Enter when user try to swith to/from win-full screen modes in Hexen2 port. In Heroes2 for that uses SDL WM ToggleFullScreen fucntion, and i believe in Hexen2 too. So, imho problem in that function, which some time works (because it works for Giddy), but sometime are not (heroes2 , which are plain SDL , and Hexen2 , which are ogl+sdl). But maybe not because of that fucntion exactly, but because of wrong return values of surface or alt.

Visually bug looks like this: You have window mode. Then you press combo (does not matter which combo is it of course, because its just SDL cheking on keys), and application swith to full-screen, but everything are black. And nothing happenes for i think 5-10 seconds. If you press many times again combo (to swith back), it's sometime swiths, sometime not. But i think we can try to invistigate, why bug happenes just when you swith from window to full-screen mode. That make me think, that or bad mode found, or no mode at all, or something like that.


I tryed to create little examples (and because of it i not create topic, to avoid all that un-understanable stuff), but, imho for now better if i will even say about it it than "hard way".

So i can't for now say exactly : bug there and there, plz fix it. Have only that sucking description for now. Maybe you can help to invisigate it better, or maybe you can just check the code of WM_Toggle function.. Or i can point you in file from Heroes2 , where that Toggle happenes, and more of it , maybe you can compile it yourself to see the problem (compilation are more or less trivial, can provide all makefiles for if it's need it).

@kas1e

if you send me the source code i can check, but without any test is hard to find it..

@afxgroup

Maybe then will be better if i will just download latest SVN of heroes2, make everything compiles fine - and will send you package, which you will need only "gmake" to see the bug ?
(also i can point in which file toggle are happens, to avoid searching).

@kas1e

can you post here the svn? i don't know where is it

@afxgroup

Of course, here is:

Quote:

You will also need the data files to run the game (i write more info about it in PM).

edit:
A bit more info for easy navigate:

src/fheroes2/game/game.cpp :

there is checking on F4 are happenes (for swith to/from fullscreen/window).:
Quote:

And src/engine/display.cpp:

Quote:

@AfxGroup
I downloaded for now Hexen2 source code, and found, that for ALT+Enter combo they also used SDL_WM_ToggleFullScreen(), so, looks like problem is here, but its not so clear still for now, because the same fucntion works for Giddy. Very possible there is some additional checking/parameters which make it works wrong ..

@kas1e

ok. thank you.
I'll take a look asap

found the problem.. but now must understand how to fix it..

Edit:
Fixed

@afxgroup

Good to know there will be a new release soon. It should be usable with vbcc :)

Last time I tried to compile it myself, some MiniGL attributes were not supported by the available version of MiniGL. Do you know more about that ?

@corto

uhm.. SDL doesn't use any new features of minigl. maybe your includes are old

@kas1e

on this link:

http://firstpersonshooters.net/Games/Hexen/2/index.html

are command for hexen2 from HunoPPC.

most work but [ and ] not work.


- on the link, commands [ and ] are located on the left of return.

- hexen2 use french and for, example: ], french keyboard is: alt+) , and located on a different place on the keyboard.


problem could be on SDL, on the game itself (setting or french keyboard used for hexen2 here is a problem,.....) but my final word is, kas1e, could you take some minuts to test [ and ] on your installed hexen2 version ???


Maybe the game should use english for compatibility....


@afxgroup

+ (game) is = on french keyboard and work here.
- (game) is ) on french keyboard and work here.

] (game) is $ on french keyboard and not work.
[ (game) is on french keyboard and not work.

the other keys work and well placed on the french keyboard.

Is it really a SDL problem ??? Must I change the keys on the default.cfg of the game ???

@Mrodfr

which version are you using?

@afxgroup

SDL1_2_13 1.2 (11.5.10)

Hope I have been clear on my explanations (I'm sure not)..

in fact on the french keyboard, there are a problem.

] (game) is $ but [ (game) is not a real key but an accent for french.

@Mrodfr

you must wait the upcoming version. it will fix that problem

@afxgroup

hey, thats great !!!

have waited half a day (hesitated) and thinked that this problem could came from:

SDL
the game itself
the user must change default.cfg on game like that
other possibility

and finally I have found a problem on SDL with luck...

EDIT: Hesitated because not want to lost precious free time by idiot questions....

@All

ok, the library is online:

http://code.google.com/p/os4sdl/

Before spreading via AmiUpdate please test it

@Mrodfr

a question is never idiot..

@afxgroup

Hello again

just tested with hexen2 and now [ and ] keys work fine on french keymaps. Thanks a lot


- Maybe I haven't a good example with hexen2 but alt+enter not work (not doing something). If I understand well for jumping on the fly to window to fullscreen.


On window mode, the game work but the mouse pointer never quit the game window. Its good ???? (logically yes).

@afxgroup

Awesome ! Can you explain in human words what problem was ? I just check the diff, but cant catch the logic. Something with active-unactive window + mouse ?

Btw, about issue4 (window get corrupted), it happenes not only for ScummVM, but for almost every SDL programm (scummvm there just as example)/

PS. Something make me feel, that "UFO" release are coming ?:)


@Mrodr
Quote:
IT not works because you have old version of Hexen2 from Huno, he should now compile new one, with new SDL. Pretty strange that you have working now keyboard layout (looks like it was not related to SDL), but, i just test by "readelf" binary of Hexen2 , and all libraryes inside are statically linked (binary not have any dinamic references to sdl.so or kind). So, even if you will replace old SDL.so on new SDL.so, there will be no changes for you, because game itself should be recompiled at all.

Quote:
Yep, that is offten done in games itself (not bug, just how game/app are done).