Reaction Checkbox and GA_Selected problem

	Bottom Previous Topic Next Topic
Register To Post

elfpipe

Posted on: 2011/5/14 19:53 #1

Just can't stay away

I'm trying to get the status of a CheckboxObject, but it doesn't work.

Here is my code:


#include <proto/exec.h>

#include <proto/intuition.h>



#include <proto/window.h>

#include <proto/checkbox.h>

#include <proto/layout.h>



#include <classes/window.h>

#include <gadgets/checkbox.h>



#include <reaction/reaction_macros.h>



#include <stdio.h>

#include <stdlib.h>



struct Window *mainwin;

BOOL window_is_open = FALSE;



Object *MainWinObj;

Object *MenusBoxObj;



void load_settings()

{

    IIntuition->SetGadgetAttrs((struct Gadget *)MenusBoxObj, mainwin, NULL,

                                GA_Selected, TRUE,

                                TAG_END);

}



void save()

{

    BOOL selected = FALSE;

    IIntuition->GetAttrs((struct Gadget *)MenusBoxObj,

                        GA_Selected, &selected,

                        TAG_DONE);



    printf("selected = %d\n", selected);

}





void open_window()

{

    if(( MainWinObj = WindowObject,

            WA_ScreenTitle, "Qt Prefs v0.1",

            WA_Title, "Qt Prefs",

            WA_Width, 300,

            WA_Height, 300,

            WA_DepthGadget, TRUE,

            WA_SizeGadget, TRUE,

            WA_DragBar, TRUE,

            WA_CloseGadget, TRUE,

            WA_Activate, TRUE,

            WINDOW_Position, WPOS_CENTERSCREEN,



            WINDOW_ParentGroup, VLayoutObject,

                LAYOUT_SpaceOuter, TRUE,

                LAYOUT_DeferLayout, TRUE,

                

                LAYOUT_AddChild, MenusBoxObj = (struct Gadget*)CheckBoxObject,

                    //GA_ID, GID_MENUS_BOX,

                    GA_RelVerify, TRUE,

                    GA_Text, "Native Menus",

                    //GA_Selected, TRUE,

                    //CHECKBOX_TextPlace, PLACETEXT_RIGHT,

                CheckBoxEnd,

                CHILD_NominalSize, TRUE,

            EndMember,

        EndWindow))

    {

        if( mainwin = (struct Window *) RA_OpenWindow(MainWinObj) )

        {

            window_is_open = TRUE;

        }

    }

}



void close_window()

{

    if (window_is_open)

    {

        IIntuition->DisposeObject( MainWinObj );



        window_is_open = FALSE;

    }

    return;

}



void event_loop()

{

    ULONG wait, signal;

    BOOL done = FALSE;



    /* Obtain the window wait signal mask. */

    IIntuition->GetAttr( WINDOW_SigMask, MainWinObj, &signal );

            

    /* Input Event Loop */

    while( !done )

    {

        wait = IExec->Wait(signal);

        if(wait & signal)

        {

            ULONG result;

            WORD Code;



            while ((result = RA_HandleInput(MainWinObj, &Code)) != WMHI_LASTMSG && done != TRUE)

            {

                switch(result & WMHI_CLASSMASK)

                {

                    case WMHI_CLOSEWINDOW:

                        done = TRUE;

                        break;

                }

            }

        }

    }

    return;

}



int main()

{

    open_window();

    load_settings();

    event_loop();

    save();

    close_window();

}

As you can see, I'm trying to set it to selected = TRUE in the load_settings() function, but it doesn't work. Also I am trying to get its status in the save() function at exit, but this doesn't work either (try checking the box and press close).

On the other hand, if I remove the comment before GA_Selected, TRUE in the window opening code, it "works".

What am I missing here??

salass00

Re: Reaction Checkbox and GA_Selected problem

Posted on: 2011/5/14 20:32 #2

Just can't stay away

I suggest you use the define CHECKBOX_Checked instead of GA_Selected as it makes it clearer what you are doing.

Quote:

BOOL selected = FALSE;
IIntuition->GetAttrs((struct Gadget *)MenusBoxObj,
GA_Selected, &selected,
TAG_DONE);

This is wrong. The selected variable should be defined as a LONG or ULONG, or if code is AmigaOS 4 specific int32 or uint32. As a general rule the variables you use with GetAttr() should always be at least 32-bit. As it is you are just getting the high 16-bits of the result which is always 0 because the only return values are TRUE or FALSE (1 or 0).

elfpipe

Re: Reaction Checkbox and GA_Selected problem

Posted on: 2011/5/14 20:52 #3

Just can't stay away

@salas00

Ahh, now I see my stupidity! I actually thought, that a BOOL was equal to an ULONG, but apparently it is typedef short. Dong!

..But just to justify my incompetence: In the autodocs under ICheckBox is says

Quote:

GA_Selected(BOOL)

And also CHECKBOX_Checked is not documented in the doc!

whose

Re: Reaction Checkbox and GA_Selected problem

Posted on: 2011/5/15 0:05 #4

Just popping in

The point is, that there is no really good documentation for beginners to AmigaOS programming. Else you would have seen how GetAttrs() is working internally. It is explained deep in the autodocs, that GetAttrs() gives back 32 bit values that you have to cast to the appropriate type afterwards (as documented in the autodocs regarding the specific attribute).

Time for a RKM overhaul...

broadblues

Re: Reaction Checkbox and GA_Selected problem

Posted on: 2011/5/15 14:07 #5

Home away from home

Quote:

whose wrote:
The point is, that there is no really good documentation for beginners to AmigaOS programming. Else you would have seen how GetAttrs() is working internally. It is explained deep in the autodocs, that GetAttrs() gives back 32 bit values that you have to cast to the appropriate type afterwards (as documented in the autodocs regarding the specific attribute).

Time for a RKM overhaul...

More documentation is certainly good but it's allready quite clear in the autodoc for IIntuition->GetAttr() that is takes a pointer to a uint32 / ULONG

Quote:

NAME
GetAttr -- Inquire the value of some attribute of an object. (V36)

SYNOPSIS
uint32 attr = GetAttr(uint32 attrId, Object *object, uint32 *storage);

FUNCTION
Inquires from the specified object the value of the specified attribute.

You always pass the address of a uint32 variable which will
receive the same value that would be passed to SetAttrs() in
the ti_Data portion of a TagItem element. See the documentation
for the class for exceptions to this general rule.

Even as a 'non beginner' I find it useful to scan the autodocs for functions I'm using pretty much every time I use them. It tends to flag up easy mistakes like this, and is better than relying on memory (or relying on *my* memory anyway!)

Antique

Re: Reaction Checkbox and GA_Selected problem

Posted on: 2011/5/15 15:11 #6

Home away from home

Or check if there are some examples in the sdk.

But yes,updated docs for us noobs would be nice.

X5000

Register To Post
	Top Previous Topic Next Topic

Currently Active Users Viewing This Thread: 2 ( 0 members and 2 Anonymous Users )