Using Flood()

	Bottom Previous Topic Next Topic
Register To Post

Steady

Using Flood()

Posted on: 2012/1/7 7:10 #1

Just popping in

Hi all,
This might sound a bit stupid, but I've been able to most things when programming the Amiga, but flood fill isn't one of them. I have always been missing something but cannot work out what it is. Now, I really need to do it for a project I am working on and it still doesn't work.

I've knocked up a quick example to see if I could get it working but even the small example doesn't work. It's meant to draw a circle and fill it. Should be easy, right? The circle draws fine, but no fill happens. Can anyone see what I am doing wrong?

Example code below, compiled with SAS/C 6.x and run/tested on AmigaOS 4.1.4:


/* Attempt to test flood fill */

#include <exec/types.h>

#include <graphics/gfx.h>

#include <graphics/gfxmacros.h>

#include <intuition/intuition.h>



#include <proto/exec.h>

#include <proto/dos.h>

#include <proto/graphics.h>

#include <proto/intuition.h>



#include <stdlib.h>

#include <stdio.h>



int main(int argc, char *argv[])

{

    struct Window *win;



    win = OpenWindowTags(NULL,

                         WA_InnerWidth,    200,

                         WA_InnerHeight,   200,

                         WA_IDCMP,         IDCMP_CLOSEWINDOW,

                         WA_Title,         "test flood",

                         WA_DragBar,       TRUE,

                         WA_CloseGadget,   TRUE,

                         WA_NoCareRefresh, TRUE,

                         WA_SmartRefresh,  TRUE,

                         TAG_DONE);

    if(win)

    {

        WORD centreX, centreY;

        struct TmpRas tr;

        LONG size;

        UBYTE *buf;



        centreX = (win->Width + win->BorderLeft - win->BorderRight) / 2;

        centreY = (win->Height + win->BorderTop - win->BorderBottom) / 2;



        SetOutlinePen(win->RPort, 1);

        SetAPen(win->RPort, 1);

        SetDrPt(win->RPort, 0xFF);

        DrawCircle(win->RPort, centreX, centreY, 25);



        size = (200 * 200) / 8;



        buf = AllocVec(size, MEMF_CHIP);

        if(buf)

        {

            InitTmpRas(&tr, buf, size);

            win->RPort->TmpRas = &tr;



            Flood(win->RPort, 0, centreX, centreY);



            win->RPort->TmpRas = NULL;

            FreeVec(buf);

        }



        Wait(1 << win->UserPort->mp_SigBit);



        CloseWindow(win);

    }

    return 0;

}

thomas

Re: Using Flood()

Posted on: 2012/1/7 9:29 #2

Not too shy to talk

Your TmpRas buffer is too small.

From the autodocs:

Quote:

NOTES
In order to use Flood, the destination RastPort must
have a valid TmpRas raster whose size is as large as
that of the RastPort.

The bitmap used in the RastPort is that of the screen, no matter how small the window is.

Use


w = GetBitMapAttr(win->RPort->BitMap,BMA_WIDTH);

h = GetBitMapAttr(win->RPort->BitMap,BMA_HEIGHT);

size = (((w + 15) & ~15) / 8) * h;

thomas

Re: Using Flood()

Posted on: 2012/1/7 10:10 #3

Not too shy to talk

Well, I tested it on OS 4 and you are right, it does not work, not matter what I do.

I changed your code like so:


/* Attempt to test flood fill */



#include <proto/exec.h>

#include <proto/dos.h>

#include <proto/graphics.h>

#include <proto/intuition.h>



#include <stdlib.h>



int main (int argc,char **argv)



{

struct Window *win;



win = OpenWindowTags(NULL,

        WA_InnerWidth,    200,

        WA_InnerHeight,   200,

        WA_IDCMP,         IDCMP_CLOSEWINDOW | IDCMP_VANILLAKEY,

        WA_Title,         "test flood",

        WA_Flags, WFLG_DRAGBAR | WFLG_CLOSEGADGET | WFLG_NOCAREREFRESH | WFLG_ACTIVATE,

        TAG_DONE);

if(win)

    {

    WORD centreX, centreY;

    struct TmpRas tr;

    UBYTE *buf;

    short w,h;

    struct Message *msg;

    short mode = argc > 1 ? atoi(argv[1]) : 1;



    Printf ("mode = %ld\n",mode);



    centreX = (win->Width + win->BorderLeft - win->BorderRight) / 2;

    centreY = (win->Height + win->BorderTop - win->BorderBottom) / 2;



    SetAPen(win->RPort, 1);

    DrawEllipse(win->RPort, centreX, centreY, 25 ,25);



    w = GetBitMapAttr (win->RPort->BitMap,BMA_WIDTH);

    h = GetBitMapAttr (win->RPort->BitMap,BMA_HEIGHT);



    buf = AllocRaster(w,h);

    if(buf)

        {

        InitTmpRas(&tr, buf, RASSIZE(w,h));

        win->RPort->TmpRas = &tr;



        SetAPen (win->RPort,2);

        SetOutlinePen (win->RPort,1);

        Flood(win->RPort, mode, centreX, centreY);



        win->RPort->TmpRas = NULL;

        FreeRaster(buf,w,h);

        }



    Wait ((1 << win->UserPort->mp_SigBit) | SIGBREAKF_CTRL_C);



    while ((msg = GetMsg (win->UserPort)))

        ReplyMsg (msg);



    CloseWindow(win);

    }



return 0;

}

It works well on WinUAE in 3.1 and 3.9 with or without Picasso96. But on OS4 I get corrupted graphics. It does *something* but no flood fill.

broadblues

Re: Using Flood()

Posted on: 2012/1/7 12:28 #4

Home away from home

I tried your test program building natively.

It didn't work here either.

First thought, from reading the description in the autodocs, it refers to pen colors of pixels etc. Pen are less meaningfull on a 16/32 bit screen, so could be an issue related to that. I would try on an 8bit workbench, but I'm running a long video conversion at the moment, so can't mess with my WB screen till it's done

Blender For OS4.x : Blues : Walker Broad

Steady

Re: Using Flood()

Posted on: 2012/1/7 13:47 #5

Just popping in

Thanks thomas and broadblues for having a look.

Firstly, I didn't realise it was the screen's rastport. I thought it was the window, so that is a definite issue. Thanks for the correction thomas.

Actually, the real program I am writing is on OS4, I just thought I would go back to a simpler example and build it up from there once it works.

On the real program I end up with the whole window being filled with corrupted rubbish when I try to floodfill. I know that what I am filling is fully enclosed. Maybe it is a 16/32 bit screen issue. I will try a few scenarios and have a look.

Cheers!

thomas

Re: Using Flood()

Posted on: 2012/1/7 13:53 #6

Not too shy to talk

Quote:

I didn't realise it was the screen's rastport. I thought it was the window, so that is a definite issue.

It's the window's rastport. But all rastports share the screen's bitmap.

And as you might have seen in my source code, you should use AllocRaster instead of AllocVec(...,MEMF_CHIP). This is because RTG systems might allow to allocate raster data in FAST mem and CHIP mem is rare.

Steady

Re: Using Flood()

Posted on: 2012/1/7 13:58 #7

Just popping in

Thanks.

Actually, the real project uses AllocRaster(). I was just experimenting in my example, but your tips are appreciated and I really should be using GetBitMapAttr() which I wasn't before, so thanks for that too.

broadblues

Re: Using Flood()

Posted on: 2012/1/7 14:13 #8

Home away from home

Quote:

It's the window's rastport. But all rastports share the screen's bitmap.

No they don't. Not on an OS4 screen with compositing enabled. Windows have their own bitmap.

Blender For OS4.x : Blues : Walker Broad

tbreeden

Re: Using Flood()

Posted on: 2012/1/7 14:29 #9

Just popping in

Maybe you can do it with Areas.

I had trouble with Flood on AOS4 and I finally gave up and used AreaEllipse
to draw a filled ellipse/circle.

I have not tried AreaFill on an arbitrarily shaped area, but it might be worth trying that.

Tom

broadblues

Re: Using Flood()

Posted on: 2012/1/7 14:32 #10

Home away from home

Have now tried on an 8bit screen, and with the example given I see the window filled with corruption, and diagonal lines.

Clearly something broken.

I'll put in abug report on it.

Blender For OS4.x : Blues : Walker Broad

Snuffy

Re: Using Flood()

Posted on: 2012/1/8 0:16 #11

Just can't stay away

I had trouble with Flood on AOS4 and I finally gave up and used AreaEllipse
to draw a filled ellipse/circle.

I had a real serious problem with the Flood in Halo. The 'Library' episode is grimist chapter of the adventure after '343 Guilty Spark'. Ooops sorry, different 'Flood' reference. BTW, HALO is a fantastic program -. I'd pay $$$ to see it on the AmigaOne.

Steady

Re: Using Flood()

Posted on: 2012/1/8 2:10 #12

Just popping in

@broadblues

Hmm. I get the same weird result in an 8-bit screen. I guess there is a bug.

Unfortunately I can't use AreaFill() because I'm filling a pie chart slice which has an arc. I guess I'll have to do my own floodfill as a workaround until it's fixed.

thomas

Re: Using Flood()

Posted on: 2012/1/8 11:39 #13

Not too shy to talk

You can use AreaMove / AreaDraw / AreaEnd to fill a random area.

Here is an example: http://thomas-rapp.homepage.t-online.de/examples/piechart.c

broadblues

Re: Using Flood()

Posted on: 2012/1/8 21:01 #14

Home away from home

@Steady
I would definetely go with Thomas' tecnique rather than flod even if flood woorked, it would be faster for sure.

@Thomas
shouldn't fcos == cosf ?

Blender For OS4.x : Blues : Walker Broad

Steady

Re: Using Flood()

Posted on: 2012/1/8 22:24 #15

Just popping in

Oh yes, definitely. Flood was always my last option but I had it in my head that the area functions wouldn't work. Happily, I was wrong.

Thanks Thomas.

thomas

Re: Using Flood()

Posted on: 2012/1/9 7:59 #16

Not too shy to talk

Quote:

@Thomas
shouldn't fcos == cosf ?

This example was developed with Dice C long ago and it has cos with double floats and fcos with single floats.

Quote:

I had it in my head that the area functions wouldn't work.

They won't work if you don't initialise the AreaInfo in addition to the TmpRas.

Steady

Re: Using Flood()

Posted on: 2012/1/9 10:41 #17

Just popping in

That's OK. I had assumed that. I might go for a few more points though as 10 degrees might have edges that are too long and straight, but we'll see.

broadblues

Re: Using Flood()

Posted on: 2012/1/9 12:49 #18

Home away from home

Quote:

This example was developed with Dice C long ago and it has cos with double floats and fcos with single floats.

Ha! Should have spotted that I used to use Dice C all the time....

Blender For OS4.x : Blues : Walker Broad

Steady

Re: Using Flood()

Posted on: 2012/1/10 13:17 #19

Just popping in

BTW. Got the pie charting stuff working thanks to the AreaFill example.

Thanks Thomas.

Register To Post
	Top Previous Topic Next Topic

Currently Active Users Viewing This Thread: 2 ( 0 members and 2 Anonymous Users )