LibNode, iobsoletes, inlines vs protos

Forced with some strange problem, maybe someone can help me. Test code:



And on compiling stange i have:

Quote:

I am sure it should be something easy like some casting or so, but just stuck with it a bit. I even do search on all LibNode entryes in whole SDK, and include all includes where find out this: no luck. As well as trying to case IntuitionBase as (struct Library *): no luck as well.

IntuitionBase * as implicitly declared in that minimal program is a struct Library *, clearly a struct Library * has no member LibBase as that is the lib base.....


would work if that's the best way would depend a lot on what context you were using it in.

@kas1e

In AmigaOS 4.x the global library base variables are by default all defined as pointers to struct Library rather than some base variables using more specific types like struct ExecBase, IntuitionBase, ...

If you want the old behavior for compatibility with older code you just need to add -D__USE_BASETYPE__ to the compiler flags.

@Andy
Thats for dopus5.library port, which is used a lot that LibNode stuff in different parts, like:



Those ones originally declared in dopus code as:



But for os4 build i comment them out, as gcc scream about:

Quote:

And so i need to keep original code as much as possible untouched, just to make it compiles on os4 with use_inline. I can of course add casts + ifdefs, but better to keep original code at first native compile as much as possible.


@salas00
Thanks ! -D__USE_BASETYPE__ did the trick

@all
I also meet in code with some obsolete on os4 intuition defines such as:

STRINGCENTER
STRINGRIGHT
STRINGLEFT

They all in the intuition/iobsolete.h , but including such a file didn't help. I also tryed to set #define INTUITION_PRE_V36_NAMES , as well as use-D__INTUITION_PRE_V36_NAMES__ : no luck. Is there another switch or the only way is to copy+paste defines to code ?

Quote:

The symbol must be named "INTUITION_PRE_V36_NAMES" and not "__INTUITION_PRE_V36_NAMES__". And you must define it before including intuition/iobsoletes.h.

@Thore
Still nope, i have:

#ifdef __amigaos4__
#define INTUITION_PRE_V36_NAMES
#include <intuition/iobsolete.h>
#endif

And have undefs. If i just do:

#ifdef __amigaos4__
#define STRINGLEFT GACT_STRINGLEFT
#define STRINGCENTER GACT_STRINGCENTER
#define STRINGRIGHT GACT_STRINGRIGHT
#endif

Then it works

Quote:

intuition/iobsolete.h is already included by several other include files, i.e. intuition/screens.h. Hence most probably it has been included already at the time you do it explicitly and therefore your own definition of INTUITION_PRE_V36_NAMES comes a bit too late. Better add -DINTUITION_PRE_V36_NAMES to the CFLAGS definition in your Makefile to make sure that the symbol is always defined.

@Thore
Quote:
Right, i just put it at very top of file and all going well (and -DINTUITION_PRE_V36_NAMES works as well). Thanks

if you want a version free working in 1.3/3.1/4.x... just keep in mind that IntuitionBase is now a struct Library* and was a struct IntuitionBase* in ancient times.

main()
{
if(((struct Library*)IntuitionBase)->lib_Version>38) {
printf("version >38n");
}
else {
printf("version <38n");
}
}

@Gilloo
Thanks !

I assume the same code can works on mos/aros as well, so i can safely avoid ifdefs and just change all versions check on such kind ?

@Gilloo
What about:

Quote:

os4 gcc says:

Quote:

Is there also some os1/3/4 way ?

Same technique: casting! (it works on all C/C++ compilers :) )

strcpy(env->font_name[FONT_DIRS],((struct GfxBase *)GfxBase)->DefaultFont->tf_Message.mn_Node.ln_Name) ;

env->font_size[FONT_DIRS]=((struct GfxBase *)GfxBase)->DefaultFont->tf_YSize ;

@Gilloo
Thanks, casting rokz.

Btw, maybe you also aware of such problem:

For os3 build we have done some inlines of some functions, like:



os4 do not like inlines, but want protos instead. it is possible to make proto includes which will not ask on linking stage for linking stub libs, and will works/compiles and on os3 and on os4 the same by the same code ?

in principle, a source code should start like that:

/* structs and constants */
#include <exec/types.h>

/* prototypes */
#include <clib/alib_protos.h>
#include <proto/exec.h>

/* functions */
/* main */

proto directories link pragmas or inlines with the source code.
If you want to make inlines, hide this in proto directory.
For your case, I suggest you to make a
proto/music.h for each system or compiler or architecture.

@kas1e

You can use fd2pragma to generate proto files that include the correct inline/pragma file type depending on what compiler is being used.

I use fd2pragma with special=38 argument to generate my proto/ files for m68k compiling and they end up looking like this:

Hello kas1e

libnode is used only for CREATING a custom library

Something like

struct mycustomlib{
struct libray libnode;
ULONG myprivatedata;
}

So it have a standard library struct = libnode
AND private data

If you are not in a library header (and you dont use a struct like mycustomlib) then you can remove libnode
and use (say) intuitionbase->version

Alain

see stormmesa2010 sources

Your compile error with regard to library base types appears to be due to a missing -nostartfiles compile and link option.

You should not be using the C library startup routines in a library.

Simon

Inline protos are OK, as long as they are defined in a way that prevents clashes between modules.

If you say "INLINE <type> MyFunc()" in a global header that all modules can read, then each module will export the name MyFunc() and you'll get multiple definitions. You have to change the inline definition to:

static INLINE <type> MyFunc(...)

Put that in your global proto header and no module will export the address to conflict with others.

@Gilloo,Salas00, tonyw

The real problem with inlines/protos looks like this:

I need to use any kind of includes, so they will works _without_ stub libs. Thats very important: to have those includes done in a way to not have any undefs on linking.

I.e. i have in code PlayModule()/IsModule()/etc function which come from some music library and which uses in the library on which i works, like this:


So for that originally on sasc #pragmas are used, like this:



For os3 build , we just use fd2pragma and generate inlines instead of pragmas (so they works on 68k gcc):



So, we have no undefs on linking, as well as i have it compiles fine with gcc. But it is for 68k, and there all those 68k registers, and so on, and of course that kind of inlines will not works when i will try to compile them for os4. More of it, gcc compiler says to me on those inlines (even if we will not take in account 68k registers):

Quote:

What force me to make new include files, which will give me no undefs on linking stage, and will works on os4 (so protos and not inlines). And so, thats what i want to do:

Will be cool to make a protos which will works and on os3 and on os4 (so that will be easy then later and for aros/mos). It is possible ? Maybe with using of SDI ? If so, how will looks like that string to make it works on gcc for os3/os4 ?: