Would be cool if it could be possible to "merge" his SDL driver into our MUI/Reaction versions
Probably Mick just build latest mplayer sources for SDL output, and that automatically make it works as intendent. Also, and with sdl output i have, and with sdl output on google-code, and with sdl output from afxgroup's release, once i run it as "mplayer -vo sdl -fs video.avi", it just messy colors and crash on exit. On mick's one all ok.
Quote:
however it still crash when you try to start a video directly from SMTube, the crash is reproducible with any availible drivers (pip96_pip, cgx_wpa and also in SDL)
@all Fixed to open sdl mode in window by default with help of Mick, but now another bug with sdl output still here : when specify -fs , its show all with messy colors and crash. While, when run it as default window mode, and then dbl-click on it or "f" , it going to fullscreen fine. Like -fs by default use some weird pixel format
What about using -fs on my build? Same issue? It could be trying to use an 8bit screenmode or something. Run it with -vv (or -vvv) and see what it says.
Edit: I noticed you said mine is OK. There's sdl_common.c as well you could look at.
No, the public version on os4depot is ok. But beta1 of muimplayer crashed and this beta3 still crashing too, but in different way --> T.19()+0x2c (section 1 @ 0x1C69EC)
@Mick Do test your version more, and , when i perss in fullscreen "C", then, it start to show the same messy colors , and the the same crashes.
I add sdl_common from latest mplayer svn, and then, by default full-screen is ok when use -fs, but then , when i press "C" it show me the same messy colors as it was before by default.
I.e. previous commond_sdl and vo_sdl are works fine in window mode, and when i dblclick to make it fullscreen, "c" thing works too. But if i run it with "-fs" , it show messy colors, and then when exit on "c" again then crash.
My bet that some format is broken in our sdl or something, and we need to find out which one and just block it.
- SDL output now by default in window (thanks to Mick) + used latest sdl_common and vo_sdl from 2014.04.03 mplayer repo). But switching resolutions by "c" crashes same as mick's version. But at least now it can be tested how sdl-speed are in on radeonhds in compare with cgx_wpa in window modes on the same vids.
- added opening/closing of bsdsocket.library manually (probably will fixes crashes samo have)
@samo go ahead post it all but i already have 4 high priority: 1. close window with video shouldnt close main gui 2. videos always opens on wb, even if i on custom screen 3. crash in sdl output when switch resolutions by "c" 4. white strips in p96overlay driver when go fullscreen
Just sounds like it's an 8bit screen when the colours are wrong. Not tested this myself since "C" freezes up my system here (unless I turn off DDC and be specific about what modes I allow).
Perhaps a whitelist could be made, and 8bit screens could be skipped. You don't want to hardcode resolutions that someone's monitor doesn't support. If there's a better solution, then of course use that.
I notice you said it crashes when you press C. For me, the entire system just freezes. Hard reset is needed. Is that what you meant?
Did you run it with verbose output? (-v, -vv, -vvv etc..)
01 - Drag&Drop of files inside the video window doesn't work with the p96_pip driver (but it works with the cgx_wpa driver)
Maybe you can re-use the old code from the afxgroup version ? In his release drag&drop functionality always worked with p96_pip
02 - Some MP4 videos are sometimes totally scramble, so they are not visible in MPlayer
Related to the video corruption you can reproduce such issue also trying to open an MP4 file and then choosing an alternative rotating view --> see menu: Video/Rotate
04 - In p96_pip driver pressing the zoom gadget doesn't work correctly, it should increase the video window in a large area, but in reality it doesn't Actually the zoom gadget will remembered the latest state of the window
(see how it should work in Reaction MPlayer with the p96_pip)
05 - In SDL driver the zoom gadget doesn't work at all
06 - Bug 811 related to double click in video window for fullscreen
07 - With latest internal beta it seems you broke the middle mouse button functionality, according to the original readme it should hidden/shown the Control panel , however since your recent modifications now pressing the middle button will hide both MPlayer windows (video and control panel aswell) so you can't control anythings
08 - Crash on drag&drop
Quote:
Crash log for task "mplayer" Generated by GrimReaper 53.16 Crash occured in module mplayer at address 0x6AE96490 Type of crash: DSI (Data Storage Interrupt) exception
09 - In Preferences --> Devices (for DVD) For now we can choose only one type of device and unit. Infact currently we have one by default and the default one is: "ide.device:1" while if you have any other hardware in you computer you need to type manually yours
Would be cool to implement it in the same manner as it is in MPlayer GUI from Denill, a choosing gadget instead of a plain textarea when the user can simply select his device and unit on the fly (and then he can save it permanently)
The other possible devices are for example:
sii3112ide.device sii3114ide.device sii3512ide.device and others..
10 - Include the newest "vo_comp driver" from Google repository
Edited by samo79 on 2014/4/3 23:47:06 Edited by samo79 on 2014/4/4 14:15:07 Edited by samo79 on 2014/4/4 17:16:21 Edited by samo79 on 2014/4/7 11:22:45 Edited by samo79 on 2014/4/7 12:46:49 Edited by samo79 on 2014/4/7 12:48:56 Edited by samo79 on 2014/4/7 13:20:17 Edited by samo79 on 2014/4/10 18:29:58 Edited by samo79 on 2014/4/10 18:36:04 Edited by samo79 on 2014/4/10 18:45:33 Edited by samo79 on 2014/4/10 18:52:26 Edited by samo79 on 2014/4/11 12:59:29 Edited by samo79 on 2014/4/11 13:55:10 Edited by samo79 on 2014/4/30 14:38:06 Edited by samo79 on 2014/4/30 14:43:42 Edited by samo79 on 2014/4/30 14:47:11 Edited by samo79 on 2014/4/30 14:48:52 Edited by samo79 on 2014/5/1 2:43:59 Edited by samo79 on 2014/5/1 2:46:47 Edited by samo79 on 2014/9/9 13:58:07 Edited by samo79 on 2014/9/9 14:02:35
I notice you said it crashes when you press C. For me, the entire system just freezes. Hard reset is needed. Is that what you meant?
For me it crashes exactly with crashlog. I.e. i run video on sdl output, go fullscreen, then press "c" : it switch screenmode, video continue plays, but looks weird like with scanlines of green color or so. Then, if i do exit from, or if i press again "c", i crashes with such stack trace:
Did you run it with verbose output? (-v, -vv, -vvv etc..)
Quote:
ram:> mplayer -v -vo sdl test.avi
...bablalba on running.... then i press fullscreen and have in shell:
SDL Mode: 0: 1920 x 1200 SDL Mode: 1: 1600 x 1200 SDL Mode: 2: 1920 x 1080 SDL Mode: 3: 1680 x 1050 SDL Mode: 4: 1280 x 960 SDL Mode: 5: 1280 x 960 SDL Mode: 6: 1280 x 920 SDL Mode: 7: 1440 x 900 SDL Mode: 8: 1280 x 900 SDL Mode: 9: 1280 x 800 SDL Mode: 10: 1024 x 768 SDL Mode: 11: 1280 x 720 SDL Mode: 12: 800 x 600 SDL Mode: 13: 640 x 512 SDL Mode: 14: 640 x 480 SDL Mode: 15: 320 x 256 SET SDL Mode: 14: 640 x 480
... then i press "c" in fullscreen mode and in shell:
<CRASH>
[mpeg4 @ 0x64b95718]header damaged Error while decoding frame! Increasing filtered audio buffer size from 65536 to 67584
I tested afxgroup's version, and it works fine when i do "c". It also says that first mode in use is mode14, but pressing on "c" didn't crash next switches. And even mode14 looks a bit different : in your version its not full screen (like no resize/scalling happens), but with agxgroup's one rescaling happens and video fit whole screen in fullscreen.
Just when i specify -fs to afxgroup's version, it then show me the same messy colors and crash the same when i swith it by "C".
2 - If you use the "Iconify" option (from the MUI MPlayer menu only) then the program will be hidden somewhere rathen then normally iconified, this issue is present since the very first port release. Original report here: http://bugs.os4depot.net/?function=viewissue&issueid=649
That one done by Fab originally like this (tested morphos version right now it is the same for non-embedded output). There even code, which says "if we in embedded mode, then iconify as usual, if not, then just hide window". Dunno why there needs to hide window (as control is loosing) and even put that "hide" on iconify menu item (probably there should be another item called Hide or something). But i think its all done like this for reasons which we don't see as we didn't have embedded outputs.
In meantime i just do the same iconify as it happens from gadget for our port, so it all will be same for both iconifies and comment out hiding of window.
Now all what remains to be done is merged LiveForIt version (fastest one with AltiVec) with his Composition rendering with Kas1e's one with this new P96_PIP.
News feed
OS4 Feedback forum
OS4Depot Feedback forum
Amigabounty forum
OpenAmiga forum
AmiCygnix forum
ABC shell forum
AmiKit forum
Cinnamon Writer forum
CodeBench forum
Digital Universe forum
Dopus 5 forum
E-UAE forum
Gnash forum
Ibrowse forum
JAmiga forum
Odyssey forum
OWB forum
Qt forum
SmartFileSystem forum
Timberwolf forum
TouchDevice forum
TuneNet forum
Unsatisfactory Software forum
Donate
