[Fixed]Use datatypes.library to open/load images/sounds

I don't know why (datatypes goal is to add an abstraction layer) but in my opinion, you will certainly be forced to read the header of the file and identify it manually.

IIRC, the current sound datatype can't handle anything better than 8-bit stereo sound.

Datatypes is yet another area that could use an overhaul. Streaming data, generating thumbnails, etc., and most importantly, and easier to use API.

Chris wrote:
@Hans

Quote:

IIRC, the current sound datatype can't handle anything better than 8-bit stereo sound.

That's not true any more, it has supported 16-bit sound since OS4.1u1.

(actually NetSurf supports reading text through Datatypes in specific circumstances - first app other than Multiview that I know of able to use text datatypes).

That's not true any more, it has supported 16-bit sound since OS4.1u1.

#include <stdlib.h>
#include <stdio.h>

// #include <amiga-align.h>
#include <datatypes/pictureclass.h>
#include <clib/alib_protos.h>
#include <proto/datatypes.h>
#include <proto/exec.h>
#include <proto/dos.h>
#include <proto/intuition.h>
#include <proto/graphics.h>
// #include <cybergraphx/cybergraphics.h>
// #include <proto/cybergraphics.h>
// #include <default-align.h>

// struct IntuitionBase *MyIntuitionBase;
// struct GfxBase *GfxBase;
// struct Library *CyberGfxBase;
struct Library *DataTypesBase;

struct MyPicture{
int Width;
int Height;
int Depth;
unsigned char *Pixels;
};

struct Picture * AllocPicture( int Width, int Height, int Depth ){
struct MyPicture *pt = NULL;
int Bytes;
Bytes = ( Depth + 7 ) / 8;
pt = IExec->AllocVec( sizeof( struct MyPicture ), MEMF_ANY|MEMF_CLEAR );
if ( pt ){
pt->Pixels = IExec->AllocVec( Width * Height * Bytes, MEMF_ANY );
pt->Width = Width;
pt->Height = Height;
pt->Depth = Depth;

if ( pt->Pixels == NULL ){
IExec->FreeVec( pt );
pt = NULL;
}
}
return pt;
}

void FreePicture( struct MyPicture *pt ){
if ( pt ){
IExec->FreeVec( pt->Pixels );
pt->Pixels = NULL;
IExec->FreeVec( pt );
}
}

struct Picture * LoadPicture( STRPTR FileName, int Alpha ){
struct MyPicture *pt = NULL;
Object *dto = NULL;
ULONG nb;
struct BitMapHeader *bmh;
struct pdtBlitPixelArray bpa;

if ( !FileName ) return NULL;

DataTypesBase = IExec->OpenLibrary( "datatypes.library", 43 );
if ( DataTypesBase ){
dto = IDataTypes->NewDTObject( FileName, DTA_GroupID, GID_PICTURE,
PDTA_DestMode, PMODE_V43,
PDTA_Remap, FALSE,
TAG_END );
if ( dto ){
nb = IDataTypes->GetDTAttrs( dto, PDTA_BitMapHeader, (ULONG)&bmh,
TAG_END );
if( nb == 1 ){
int resread;
printf( "Dimensions : %dx%dx%d\n", bmh->bmh_Width, bmh->bmh_Height, bmh->bmh_Depth );
/* Allocation de la structure Picture et du buffer m?moire */
pt = AllocPicture( bmh->bmh_Width, bmh->bmh_Height, ( 3 + Alpha ) * 8 );
if ( pt ){
bpa.MethodID = PDTM_READPIXELARRAY;
bpa.pbpa_PixelData = pt->Pixels;
bpa.pbpa_PixelFormat = Alpha?PBPAFMT_RGBA:PBPAFMT_RGB;
bpa.pbpa_PixelArrayMod = bmh->bmh_Width * ( 3 + Alpha );
bpa.pbpa_Left = 0;
bpa.pbpa_Top = 0;
bpa.pbpa_Width = bmh->bmh_Width;
bpa.pbpa_Height = bmh->bmh_Height;
resread = IDataTypes->DoDTMethodA( dto, (Msg)&bpa );
}else{
printf( "Impossible d'allouer de la m?moire pour la structure Picture\n" );
}
}else{
printf( "Impossible de lire les informations de l'image\n" );
}
IDataTypes->DisposeDTObject( dto );
}else{
printf( "Echec dans le chargement du fichier\n" );
}
IExec->CloseLibrary( DataTypesBase );
}else{
printf( "Impossible d'ouvrir la datatypes.library ver 43+\n" );
}
return pt;
}

AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c: In function 'AllocPicture':
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:44: warning: return from incompatible pointer type
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c: In function 'LoadPicture':
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:77: warning: assignment from incompatible pointer type
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:87: warning: dereferencing type-punned pointer will break strict-aliasing rules
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:87: warning: passing argument 3 of 'IDataTypes->DoDTMethodA' from incompatible pointer type
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:87: error: too few arguments to function 'IDataTypes->DoDTMethodA'
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:102: warning: return from incompatible pointer type

void * NullWindow = NULL;
void * NullRequester = NULL;
resread = IDataTypes->DoDTMethodA( dto, NullWindow, NullRequester, (Msg)&bpa);

AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c: In function 'AllocPicture':
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:44: warning: return from incompatible pointer type
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c: In function 'LoadPicture':
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:80: warning: assignment from incompatible pointer type
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:90: warning: dereferencing type-punned pointer will break strict-aliasing rules
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:105: warning: return from incompatible pointer type
AmiDE_3D.c: At top level:
AmiDARK:Shared/Sound/Sound.c:15: warning: 'DELoadSound' defined but not used
AmiDARK:Shared/Sound/Sound.c:45: warning: 'DEDeleteSound' defined but not used
gcc -mcrt=newlib -O3 -Wall -gstabs -DMINIGL -o AmiDE_3D.exe.debug AmiDE_3D.o -lm -lGL -lGLUT -lglpng -lpng -lz
AmiDE_3D.o: In function `LoadPicture':
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:69: undefined reference to `IDataTypes'
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:69: undefined reference to `IDataTypes'
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:74: undefined reference to `IDataTypes'
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:97: undefined reference to `IDataTypes'
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:90: undefined reference to `IDataTypes'
make: *** [AmiDE_3D.exe] Error 1

[b]It's worth chucking a quick mention of my drawing.datatype OA project in here: http://www.openamiga.org/?function=viewproject&projectid=51

Why?

AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c: In function 'LoadPicture':
AmiDARK:Shared/AmigaOS4/AmigaOS_DataTypes.c:91: warning: dereferencing type-punned pointer will break strict-aliasing rules

resread = IDataTypes->DoDTMethod( dto, NullStructPTR, NullStructPTR, (Msg)&bpa );

resread = IDataTypes->DoDTMethodA( dto, NullStructPTR, NullStructPTR, (Msg)&bpa );

Hans wrote:

Someone made a new one that was much more flexible, but I don't think that it was ever adopted as standard (it's on os4depot, IIRC).

Datatypes is yet another area that could use an overhaul. Streaming data, generating thumbnails, etc., and most importantly, and easier to use API.

Hans